refactor: Switch ESLint to unicorn rules

.changeset/mean-ants-pretend.md

@@ -0,0 +1,13 @@
+---
+'@joyid/ethereum-provider': patch
+'@joyid/bitcoin': patch
+'@joyid/miniapp': patch
+'@joyid/common': patch
+'@joyid/ethers': patch
+'@joyid/nostr': patch
+'@joyid/wagmi': patch
+'@joyid/ckb': patch
+'@joyid/evm': patch
+---
+
+Use unicorn rules as linter rule

eslint.config.mjs

@@ -0,0 +1,20 @@
+import unjs from 'eslint-config-unjs'
+import prettierConfig from 'eslint-plugin-prettier/recommended'
+
+export default unjs(
+  {
+    ignores: ['**/.nuxt', 'dist/**', '**/dist'],
+  },
+  {
+    rules: {
+      'unicorn/no-null': 'off',
+      'unicorn/number-literal-case': 'off',
+      'unicorn/prefer-optional-catch-binding': 'off',
+      'unicorn/catch-error-name': 'off',
+      'unicorn/filename-case': 'off',
+      '@typescript-eslint/no-non-null-assertion': 'off',
+      'unicorn/expiring-todo-comments': 'off',
+    },
+  },
+  prettierConfig
+)

examples/bitcoin-demo/src/env/index.ts

@@ -9,4 +9,4 @@ export const BTC_SERVICE_URL: string =
 export const BTC_SERVER_TOKEN: string =
   import.meta.env.VITE_APP_BTC_SERVER_TOKEN ?? ''
 
-export const MIN_UTXO_AMOUNT = 10000
+export const MIN_UTXO_AMOUNT = 10_000

examples/bitcoin-demo/src/hooks/localStorage.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-argument */
-/* eslint-disable @typescript-eslint/ban-ts-comment */
 import { createEffect } from 'solid-js'
 import {
   createStore,

examples/bitcoin-demo/src/hooks/useSendSuccessToast.tsx

@@ -55,7 +55,7 @@ export const useSendSuccessToast = () => {
       },
       {
         position: 'bottom-center',
-        duration: 10000,
+        duration: 10_000,
         unmountDelay: 0,
       }
     )

examples/bitcoin-demo/src/index.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 /* @refresh reload */
 import './global.css'
 
@@ -7,7 +6,7 @@ import { Router } from '@solidjs/router'
 
 import App from './app'
 
-const root = document.getElementById('root')
+const root = document.querySelector('#root')
 
 if (import.meta.env.DEV && !(root instanceof HTMLElement)) {
   throw new Error(

examples/bitcoin-demo/src/pages/home.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { type Component, Match, Show, Switch, onMount } from 'solid-js'
 import { writeClipboard } from '@solid-primitives/clipboard'
 import { A, Navigate, useLocation } from '@solidjs/router'

examples/bitcoin-demo/src/pages/root.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { type Component, Show, createSignal } from 'solid-js'
 import { Navigate, useNavigate } from '@solidjs/router'
 import { useAuthData } from '../hooks/localStorage'

examples/bitcoin-demo/src/pages/send.tsx

@@ -44,7 +44,7 @@ export const SendBtc: Component = () => {
       tos: [
         {
           address: toAddress(),
-          value: parseInt((Number(toAmount()) * 1e8).toString(), 10),
+          value: Number.parseInt((Number(toAmount()) * 1e8).toString(), 10),
         },
       ],
       feeRate: 1,

examples/bitcoin-demo/vite.config.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { defineConfig } from 'vite'
 import solidPlugin from 'vite-plugin-solid'
 import wasm from 'vite-plugin-wasm'
@@ -7,12 +6,7 @@ import topLevelAwait from 'vite-plugin-top-level-await'
 import { nodePolyfills } from 'vite-plugin-node-polyfills'
 
 export default defineConfig({
-  plugins: [
-    wasm(),
-    topLevelAwait(),
-    solidPlugin(),
-    nodePolyfills()
-  ],
+  plugins: [wasm(), topLevelAwait(), solidPlugin(), nodePolyfills()],
   server: {
     port: 3000,
   },

examples/ckb-demo/src/i18n/index.ts

@@ -13,4 +13,4 @@ i18n.use(initReactI18next).init({
   cache: localStorage,
 })
 
-export default i18n
+export { default } from 'i18next'

examples/ckb-demo/src/main.tsx

@@ -36,7 +36,7 @@ export const App: React.FC = () => {
   )
 }
 
-createRoot(document.getElementById('root')!).render(
+createRoot(document.querySelector('#root')!).render(
   <React.StrictMode>
     <App />
   </React.StrictMode>

examples/ckb-demo/src/pages/SignCkbRawTx/index.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/ban-ts-comment */
 import { useState } from 'react'
 import { Button, VStack, Input, Text, Link, useToast } from '@chakra-ui/react'
 import { Navigate, useNavigate } from 'react-router-dom'
@@ -26,7 +25,7 @@ import { RoutePath } from '../../route/path'
 import { CKB_INDEXER_URL, CKB_RPC_URL, COTA_AGGREGATOR_URL } from '../../env'
 
 const info: InscriptionInfo = {
-  maxSupply: BigInt(2100_0000),
+  maxSupply: BigInt(21_000_000),
   mintLimit: BigInt(1000),
   xudtHash: '',
   mintStatus: 0,

examples/ckb-demo/src/pages/SignMessage/index.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-explicit-any */
 import { useState } from 'react'
 import { Button, Textarea, VStack, useToast, Box } from '@chakra-ui/react'
 import {

examples/evm-demo/src/chains/index.ts

@@ -11,6 +11,7 @@ export interface Chain {
 
 export const EthSepolia: Chain = chainList[0]
 
+// eslint-disable-next-line unicorn/no-array-reduce
 export const Chains = chainList.reduce<Record<string, Chain>>((prev, acc) => {
   prev[acc.name] = acc
   return prev

examples/evm-demo/src/hooks/localStorage.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-argument */
-/* eslint-disable @typescript-eslint/ban-ts-comment */
 import { createEffect } from 'solid-js'
 import {
   createStore,

examples/evm-demo/src/hooks/provider.tsx

@@ -4,12 +4,11 @@ import { createMemo } from 'solid-js'
 
 export const SepoliaNetwork = {
   name: 'Ethereum Sepolia',
-  chainId: 11155111,
+  chainId: 11_155_111,
 }
 
 export const useProvider = () => {
   const { authData } = useAuthData()
-  // eslint-disable-next-line solid/reactivity
   return createMemo(() =>
     authData.name
       ? new providers.JsonRpcBatchProvider(authData.rpcURL, {

examples/evm-demo/src/hooks/useSendSuccessToast.tsx

@@ -57,7 +57,7 @@ export const useSendSuccessToast = () => {
       },
       {
         position: 'bottom-center',
-        duration: 10000,
+        duration: 10_000,
         unmountDelay: 0,
       }
     )

examples/evm-demo/src/index.tsx

@@ -6,7 +6,7 @@ import { Router } from '@solidjs/router'
 
 import App from './app'
 
-const root = document.getElementById('root')
+const root = document.querySelector('#root')
 
 if (import.meta.env.DEV && !(root instanceof HTMLElement)) {
   throw new Error(
@@ -20,6 +20,6 @@ render(
       <App />
     </Router>
   ),
-  // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+
   root!
 )

examples/evm-demo/src/pages/home.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import {
   type Component,
   For,

examples/evm-demo/src/pages/send-erc20.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Navigate, useLocation, useNavigate } from '@solidjs/router'
 import toast from 'solid-toast'
 import { type Component, Show, createSignal, onMount } from 'solid-js'

examples/evm-demo/src/pages/send.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-non-null-assertion */
 import { Navigate, useLocation, useNavigate } from '@solidjs/router'
 import toast from 'solid-toast'
 import { type Component, Show, createSignal, onMount } from 'solid-js'

examples/evm-demo/src/pages/sign-typed-data.tsx

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/no-unsafe-argument */
 import { Navigate, useLocation, useNavigate } from '@solidjs/router'
 import { type Component, Show, createSignal } from 'solid-js'
 import toast from 'solid-toast'

examples/rainbowkit-demo/src/main.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable unicorn/prefer-query-selector */
 import React from 'react'
 import ReactDOM from 'react-dom/client'
 import App from './App.tsx'

examples/wagmi-demo/src/main.tsx

@@ -1,3 +1,4 @@
+/* eslint-disable unicorn/prefer-query-selector */
 import React from 'react'
 import ReactDOM from 'react-dom/client'
 import { App } from './App.tsx'

package.json

@@ -34,19 +34,15 @@
   "devDependencies": {
     "@changesets/changelog-github": "^0.5.0",
     "@changesets/cli": "^2.27.5",
-    "@eslint/js": "^9.4.0",
-    "@types/eslint__js": "^8.42.3",
     "eslint": "9.4.0",
-    "eslint-config-love": "52.0.0",
     "eslint-config-prettier": "9.1.0",
+    "eslint-config-unjs": "0.3.2",
     "eslint-plugin-import": "2.29.1",
     "eslint-plugin-prettier": "5.1.3",
-    "eslint-plugin-promise": "6.2.0",
     "prettier": "3.3.1",
     "simple-git-hooks": "^2.11.1",
     "tsup": "^7.2.0",
     "typescript": "^5.2.2",
-    "typescript-eslint": "^7.12.0",
     "vite": "5.2.12",
     "vitest": "1.6.0"
   },

packages/bitcoin/src/index.ts

@@ -1,5 +1,3 @@
-/* eslint-disable @typescript-eslint/strict-boolean-expressions */
-
 import {
   createBlockDialog,
   openPopup as p,
@@ -25,8 +23,6 @@ import {
 
 export const openPopup = p
 
-export type { BtcConfig }
-
 const JOYID_STORAGE_KEY = 'joyid:bitcoin::account'
 
 export const buildSignPsbtURL = (
@@ -58,9 +54,9 @@ export const buildSignPsbtsURL = (
 const getRequestNetwork = (
   requestAddressType: BtcConfig['requestAddressType']
 ): RequestNetwork =>
-  requestAddressType !== null
-    ? (`btc-${requestAddressType}` as RequestNetwork)
-    : 'btc-auto'
+  requestAddressType == null
+    ? 'btc-auto'
+    : (`btc-${requestAddressType}` as RequestNetwork)
 
 export const buildConnectUrl = (
   { requestAddressType, ...config }: BtcConfig & { redirectURL: string },
@@ -136,9 +132,8 @@ export const requestAccounts = async (): Promise<string[]> => {
 }
 
 export const getAccounts = (): string[] =>
-  connectedAccount.address != null
-    ? [connectedAccount.address]
-    : safeExec(() => {
+  connectedAccount.address == null
+    ? safeExec(() => {
         const json = localStorage.getItem(JOYID_STORAGE_KEY)
         if (json) {
           const account = JSON.parse(json)
@@ -148,6 +143,7 @@ export const getAccounts = (): string[] =>
         }
         return []
       }) ?? []
+    : [connectedAccount.address]
 
 export const getPublicKey = (): string | null => {
   if (connectedAccount.pubkey) {
@@ -341,3 +337,5 @@ export const signPsbtCallback = (uri?: string): WithState & { tx: string } => {
     tx,
   }
 }
+
+export { type BtcConfig } from '@joyid/common'

packages/bitcoin/tsup.config.ts

@@ -7,6 +7,6 @@ import config from '../../tsup-base.config'
 export default defineConfig({
   ...config,
   name,
-  external: [...Object.keys(dependencies)],
+  external: Object.keys(dependencies),
   platform: 'browser',
 })

packages/ckb/src/constants.ts

@@ -1,4 +1,3 @@
-/* eslint-disable @typescript-eslint/consistent-type-assertions */
 import { type CellDep, type Script } from '@joyid/common'
 
 const TestnetInfo = {