Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: run 'capsule test' without docker #96

Merged
merged 5 commits into from
Apr 20, 2023
Merged

chore: run 'capsule test' without docker #96

merged 5 commits into from
Apr 20, 2023

Conversation

jjyr
Copy link
Collaborator

@jjyr jjyr commented Apr 20, 2023

Replace #31

  1. Exclude the tests crate in the cargo workspace.
    1. contracts may need to reference other contracts. Putting them in the same workspace simplifies this.
  2. Run capsule test without docker.
    1. The trailing style args do not work with the clap 2.33.x, we should support it after upgrading the clap.

@jjyr jjyr requested a review from blckngm as a code owner April 20, 2023 03:24
@jjyr jjyr mentioned this pull request Apr 20, 2023
Closed
blckngm
blckngm reviewed Apr 20, 2023
View reviewed changes
src/tester.rs Outdated Show resolved Hide resolved
@blckngm
Copy link
Collaborator

blckngm commented Apr 20, 2023

Should we mention in README that capsule test is just cd tests && cargo test -- --nocapture?

@jjyr
Copy link
Collaborator Author

jjyr commented Apr 20, 2023 •
edited
Loading

Should we mention in README that capsule test is just cd tests && cargo test -- --nocapture?

We have mentioned that in the cli help.

https://github.com/nervosnetwork/capsule/pull/96/files#diff-6910a2e2367676eb3de8f900c4a87c67af79b78b4c66dd6ab6666ce45a122726R117

I doubt how many people will notice the hint in the README. I think we should mention it in tutorials.

@jjyr jjyr requested a review from blckngm April 20, 2023 05:58
blckngm
blckngm reviewed Apr 20, 2023
View reviewed changes
src/tester.rs Show resolved Hide resolved
@jjyr jjyr requested a review from blckngm April 20, 2023 07:59
@jjyr jjyr enabled auto-merge April 20, 2023 08:22
@jjyr jjyr linked an issue Apr 20, 2023 that may be closed by this pull request
Maybe don't put contracts and tests in the same workspace #85
Closed
@jjyr jjyr added this pull request to the merge queue Apr 20, 2023
Merged via the queue into develop with commit 1cea305 Apr 20, 2023
@jjyr jjyr deleted the generate-tests-in-standalone-crate branch April 21, 2023 02:12
@jjyr jjyr mentioned this pull request Apr 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blckngm blckngm blckngm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maybe don't put contracts and tests in the same workspace
2 participants
@jjyr @blckngm