Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: only fetch blocks for filter matched #154

Merged
merged 1 commit into from
Oct 10, 2023
Merged

Conversation

quake
Copy link
Member

@quake quake commented Oct 9, 2023

light client will request blocks from full node when rpc fetch_header was called, I think it's unnecessary, it should be only requested for filter matched blocks.

@quake quake requested a review from yangby-cryptape October 9, 2023 23:48
@codecov-commenter
Copy link

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (578dcc6) 69.78% compared to head (8a06cab) 69.83%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #154      +/-   ##
===========================================
+ Coverage    69.78%   69.83%   +0.05%     
===========================================
  Files           25       25              
  Lines         6395     6409      +14     
===========================================
+ Hits          4463     4476      +13     
- Misses        1932     1933       +1     
Flag Coverage Δ
unittests 69.83% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ocols/light_client/components/send_blocks_proof.rs 94.28% <100.00%> (-0.65%) ⬇️
src/protocols/light_client/mod.rs 69.12% <100.00%> (ø)
src/protocols/light_client/peers.rs 61.56% <100.00%> (+0.34%) ⬆️
src/utils/network.rs 92.95% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@quake quake merged commit dfcd2cc into develop Oct 10, 2023
7 checks passed
@quake quake deleted the quake/no-fetch-block branch November 22, 2023 07:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants