Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cargo +nightly fmt with wrap_comments = true #2485

Closed
wants to merge 2 commits into from

Conversation

keroro520
Copy link
Contributor

@keroro520 keroro520 commented Dec 30, 2020

Commits:

  • 2c39c0a Execute cargo +nightly fmt --all with option wrap_comments = true, to wrap some long code comments.
  • 21b6367 The default wrapping format is mess for some comments; I adjust these manurally.

I did not update rustfmt.toml for the below reasons:

  • wrapping comments mess some math formulas and doc links;
  • wrap_comments is unstable yet; it requires nightly Rust;
  • wrapping comments is a less important task.

Ref:

* wrap_comments = true; comment_width = 100;
@keroro520 keroro520 marked this pull request as ready for review December 30, 2020 10:43
@keroro520
Copy link
Contributor Author

I am not sure whether wrapping comments is meaningful. Expect response.

@doitian
Copy link
Member

doitian commented Feb 7, 2021

It has little benefits and is easy to conflict other PRs.

@keroro520
Copy link
Contributor Author

Less benefit

@keroro520 keroro520 closed this Feb 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants