Fix orphan pool for long pending tx issues

[chenyukang]

What problem does this PR solve?

Project Godwoken found that some tx will stay in pending for a long time. After analyzing the log(at most 4 hours), we found tx may unexpectedly stay in orphan pool for the scenario transaction chain. For example, tx1 -> tx2, after tx1 is submitted tx2 stayed in pending for a long time, actually tx2 wasn't submitted into txpool.

Problem Summary:

What is changed and how it works?

Fix the issues in process_orphan_tx which may forget some txs in orphan pool. There are 3 issues this PR targeted to resolve:

• 1. find_by_previous was only returning one tx by searching with input(because the tx in orphan pool may have conflicts), which may cause issue when there are multiple child tx for one parent tx, process_orphan_tx may can not process all of them.
• 2. The evict time interval was 2 * max_block_interval, which is 96 seconds, this is too short for the delay of networking, and we didn't send Reject to filter, which may make the node don't broadcast them later.
• 3. For the conflicted tx scenario, since we can not resolve all inputs in orphan pool, we can not add Replace-by-fee checking rules for them, so I change the code to use HashMap<OutPoint, HashSet<ProposalShortId>>, so we don't handle the conflict in orphan pool.

What's Changed:

Related changes

• PR to update owner/repo:
• Need to cherry-pick to the release branch

Check List

Tests

• Unit test
• Integration test
• Manual test (add detailed scripts or steps below)
• No code ci-runs-only: [ quick_checks,linters ]

Side effects

• Performance regression
• Breaking backward compatibility

Release note

Title Only: Include only the PR title in the release note.

[doitian]

Please choose the release note for the PR.

[quake]

bitcoin will expire orphan tx after 20 mintues: https://github.com/bitcoin/bitcoin/blob/2a349f9ea5de9f0157cd117289996e8640473a6d/src/txorphanage.cpp#L14 which equals 2 block interval, so we use the 2 * 48 in our code. we may need to double check the impaction of increasing it to 100 block interval.

[chenyukang]

one issue with increasing it to 100 block interval is we may store more orphan tx in the pool, but we still have 100 max orphan numbers limit, so it should be ok.

on the other hand, the previous 96 seconds is too short in practice, we have observed this kind of case, so let's keep this change.