Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: Add a check for RBF to avoid invalid cell deps #4216

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

  • We need more logs when debugging txpool issues
  • For RBF, if the new tx's cell comes from the conflicted tx, we reject RBF.

Problem Summary:

What is changed and how it works?

  • Add more logs for debugging
  • Add a rule for RBF

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner October 31, 2023 10:58
@chenyukang chenyukang requested review from zhangsoledad and removed request for a team October 31, 2023 10:58
@chenyukang chenyukang changed the base branch from develop to rc/v0.112.x October 31, 2023 10:58
@zhangsoledad zhangsoledad merged commit baf1d0d into nervosnetwork:rc/v0.112.x Nov 1, 2023
33 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants