Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport: RBF will also replace tx not in Pending #4232

Merged
merged 2 commits into from
Nov 16, 2023
Merged

Backport: RBF will also replace tx not in Pending #4232

merged 2 commits into from
Nov 16, 2023

Conversation

chenyukang
Copy link
Collaborator

What problem does this PR solve?

To keep it consistent, now RBF will also can replace tx not in Pending.

Problem Summary:

What is changed and how it works?

Drop Rule #6 and fix tests.

What's Changed:

Related changes

  • PR to update owner/repo:
  • Need to cherry-pick to the release branch

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code ci-runs-only: [ quick_checks,linters ]

Side effects

  • Performance regression
  • Breaking backward compatibility

Release note 

None: Exclude this PR from the release note.

@chenyukang chenyukang requested a review from a team as a code owner November 15, 2023 12:19
@quake quake merged commit 770d6a2 into nervosnetwork:rc/v0.112.x Nov 16, 2023
34 of 35 checks passed
@doitian doitian mentioned this pull request Nov 17, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eval-exec eval-exec eval-exec approved these changes

@quake quake quake approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chenyukang @quake @eval-exec