-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Fuzz test CKBProtocolHandler and ServiceProtocol #4488
base: develop
Are you sure you want to change the base?
Conversation
shared/src/shared_builder.rs
Outdated
} | ||
|
||
let db = { | ||
let db_dir = PathBuf::from("/tmp/tmp.db"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggest using tempfile::temp_dir()
.
sync/Cargo.toml
Outdated
@@ -24,7 +24,7 @@ ckb-chain-spec = { path = "../spec", version = "= 0.117.0-pre" } | |||
ckb-channel = { path = "../util/channel", version = "= 0.117.0-pre" } | |||
ckb-traits = { path = "../traits", version = "= 0.117.0-pre" } | |||
ckb-error = { path = "../error", version = "= 0.117.0-pre" } | |||
ckb-tx-pool = { path = "../tx-pool", version = "= 0.117.0-pre" } | |||
ckb-tx-pool = { path = "../tx-pool", version = "= 0.117.0-pre", features = ["internal"] } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should feature = ["internal"]
be added under [dev-dependencies]
?
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
Add fuzz test: