fix: It's unnecessary to use process.exit to skip create PR. (#2947)

nervosnetwork · Nov 20, 2023 · d168e73 · d168e73 · github-actions · Nov 20, 2023
1 parent c69258f
commit d168e73
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 6 deletions.
diff --git a/.github/workflows/update_ckb_client_versions.yml b/.github/workflows/update_ckb_client_versions.yml
@@ -25,7 +25,7 @@ jobs:
         id: update_versions
         run: |
           npm run update:client-versions
-          git add .ckb-version .ckb-light-version
+          git add .ckb-version .ckb-light-version compatible.json
 
       - name: Set GPG
         uses: crazy-max/ghaction-import-gpg@v5

diff --git a/.github/workflows/update_neuron_compatible.yml b/.github/workflows/update_neuron_compatible.yml
@@ -31,7 +31,6 @@ jobs:
           git add compatible.json
 
       - name: Set GPG
-        if: ${{ success() }}
         uses: crazy-max/ghaction-import-gpg@v5
         with:
           gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
@@ -40,7 +39,6 @@ jobs:
           git_commit_gpgsign: true
 
       - name: Open PR to RC branch
-        if: ${{ success() }}
         uses: peter-evans/create-pull-request@v5
         with:
           title: Update Neuron compatibility table

diff --git a/compatible.json b/compatible.json
@@ -54,4 +54,4 @@
       "light": []
     }
   }
-}
+}
diff --git a/scripts/add-neuron-version-in-compatibility-table.js b/scripts/add-neuron-version-in-compatibility-table.js
@@ -18,8 +18,6 @@ const exec = () => {
   if (newNeuronVersion && lastNeuronVersion !== newNeuronVersion) {
     info.compatible[newNeuronVersion] = info.compatible[lastNeuronVersion]
     fs.writeFileSync(compatiblePath, `${JSON.stringify(info, null, 2)}\r\n`)
-  } else {
-    process.exit(1)
   }
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -54,4 +54,4 @@ @@
           "light": []
         }
       }
-    }
+    }