refactor: remove ckb-sdk-core and replace with lumos #2843

zhangyouxin · 2023-09-18T15:21:32Z

Description

remove ckb-sdk-core

Resolve: Magickbase/neuron-public-issues#202

packages/neuron-wallet/src/utils/signWitnesses.ts

silySuper · 2023-09-19T07:54:58Z

/package.
Packaging for test is done in 6232725050. @silySuper

silySuper · 2023-09-19T09:15:54Z

This package https://github.com/nervosnetwork/neuron/actions/runs/6232725050 pop up an error when I click the app icon.

Uncaught Exception:
Error: Cannot find module '@nervosnetwork/ckb-sdk-rpc'
Require stack:

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/utils/ckb-rpc.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/services/networks.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/controllers/export-debug.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/controllers/app/menu.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/controllers/app/index.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/main.js

at Module._resolveFilename (node:internal/modules/cjs/loader:1054:15)
at n._resolveFilename (node:electron/js2c/browser_init:2:109960)
at Module._load (node:internal/modules/cjs/loader:900:27)
at f._load (node:electron/js2c/asar_bundle:2:13330)
at Module.require (node:internal/modules/cjs/loader:1120:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/utils/ckb-rpc.js:13:39)
at Module._compile (node:internal/modules/cjs/loader:1241:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1296:10)
at Module.load (node:internal/modules/cjs/loader:1096:32)

zhangyouxin · 2023-09-19T11:33:04Z

This package https://github.com/nervosnetwork/neuron/actions/runs/6232725050 pop up an error when I click the app icon.

Uncaught Exception: Error: Cannot find module '@nervosnetwork/ckb-sdk-rpc' Require stack:

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/utils/ckb-rpc.js

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/services/networks.js

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/controllers/export-debug.js

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/controllers/app/menu.js

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/controllers/app/index.js

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/main.js

at Module._resolveFilename (node:internal/modules/cjs/loader:1054:15) at n._resolveFilename (node:electron/js2c/browser_init:2:109960) at Module._load (node:internal/modules/cjs/loader:900:27) at f._load (node:electron/js2c/asar_bundle:2:13330) at Module.require (node:internal/modules/cjs/loader:1120:19) at require (node:internal/modules/cjs/helpers:103:18) at Object. (/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/3D6339A8-5D53-4ECB-88B7-2D65BBC6DDEE/d/Neuron.app/Contents/Resources/app.asar/dist/utils/ckb-rpc.js:13:39) at Module._compile (node:internal/modules/cjs/loader:1241:14) at Module._extensions..js (node:internal/modules/cjs/loader:1296:10) at Module.load (node:internal/modules/cjs/loader:1096:32)

looks like there was a phatom dep, I'll fix this later

_typos.toml

packages/neuron-wallet/src/types/ckbComponents.d.ts

Co-authored-by: Yonghui Lin <[email protected]>

packages/neuron-wallet/src/types/ckbComponents.d.ts

zhangyouxin · 2023-09-22T03:28:50Z

/package

Packaging for test is done in 6269758509. @zhangyouxin

silySuper · 2023-09-22T07:02:40Z

Another bug pop up in package 6269758509.

Uncaught Exception:
Error: Cannot find module 'jsbi'
Require stack:

/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/toolkit/lib/normalizers.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/toolkit/lib/index.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/base/lib/indexer.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/base/lib/index.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/config-manager/lib/manager.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/config-manager/lib/index.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/utils/scriptAndAddress.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/models/keys/address.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/models/keys/key.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/services/addresses.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/controllers/export-debug.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/controllers/app/menu.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/controllers/app/index.js
/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/dist/main.js

at Module._resolveFilename (node:internal/modules/cjs/loader:1054:15)
at n._resolveFilename (node:electron/js2c/browser_init:2:109960)
at Module._load (node:internal/modules/cjs/loader:900:27)
at f._load (node:electron/js2c/asar_bundle:2:13330)
at Module.require (node:internal/modules/cjs/loader:1120:19)
at require (node:internal/modules/cjs/helpers:103:18)
at Object. (/private/var/folders/0g/2f1xzp_x46d7kr74mybk85jc0000gn/T/AppTranslocation/FE6BD158-2555-49B5-B920-D2086C3CD470/d/Neuron 2.app/Contents/Resources/app.asar/node_modules/@ckb-lumos/toolkit/lib/normalizers.js:20:36)
at Module._compile (node:internal/modules/cjs/loader:1241:14)
at Module._extensions..js (node:internal/modules/cjs/loader:1296:10)
at Module.load (node:internal/modules/cjs/loader:1096:32)

zhangyouxin · 2023-09-22T08:54:03Z

weird, peerDependency of @ckb-lumos/toolkit: jsbi@^4.1 is not installed in neuron

Keith-CY · 2023-09-22T09:30:35Z

weird, peerDependency of @ckb-lumos/toolkit: jsbi@^4.1 is not installed in neuron

peerDependency is not installed automatically when npm is of some old versions.

Ref: https://nodejs.org/en/blog/npm/peer-dependencies

Update:

I found that Neuron is using yarn, which doesn't install peerDependency automatically too

Ref: https://yarnpkg.com/cli/add

zhangyouxin · 2023-09-22T13:10:28Z

/package

Packaging for test is done in 6274719391. @zhangyouxin

This reverts commit 22e2823.

zhangyouxin · 2023-09-25T01:46:52Z

/package

Packaging for test is done in 6274719391. @zhangyouxin

The jsbi problem still exists, I find the peerDep is not a necessary in @ckb-lumos/toolkit, I would like to remove the peerDep in @ckb-lumos/toolkit and then the problem will be gone for all projects using @ckb-lumos/toolkit.

homura · 2023-10-13T06:37:50Z

The jsbi problem still exists, I find the peerDep is not a necessary in @ckb-lumos/toolkit, I would like to remove the peerDep in @ckb-lumos/toolkit and then the problem will be gone for all projects using @ckb-lumos/toolkit.

The next release has been released as 0.21.0-next.1, and it should solve the problem

…-core

…ctor-ckb-sdk-core

zhangyouxin · 2023-10-13T08:27:31Z

/package
Packageing failed in 6505870188. @zhangyouxin
Packaging for test is done in 6505870188. @zhangyouxin

silySuper · 2023-10-16T01:27:01Z

/package
Packaging for test is done in 6527846838. @silySuper

silySuper · 2023-10-20T08:05:02Z

Verified.

zhangyouxin added 5 commits September 18, 2023 21:44

refactor: sign witnesses

816fdd7

refactor: use lumos rpc and update test cases

fad12a9

Merge branch 'develop' into refactor-ckb-sdk-core

2646942

chore: remove ckb-sdk-core from dep list

92a0a2a

chore: remove unused mock

566eb57

zhangyouxin requested review from Keith-CY, homura, WhiteMinds, devchenyan and yanguoyu September 18, 2023 15:21

zhangyouxin mentioned this pull request Sep 19, 2023

Refactoring With Lumos Magickbase/neuron-public-issues#177

Closed

35 tasks

yanguoyu reviewed Sep 19, 2023

View reviewed changes

packages/neuron-wallet/src/utils/signWitnesses.ts Show resolved Hide resolved

yanguoyu approved these changes Sep 19, 2023

View reviewed changes

homura approved these changes Sep 19, 2023

View reviewed changes

zhangyouxin added 2 commits September 20, 2023 20:44

refactor: remove ckb-sdk-rpc and use @ckb-lumos/rpc

51ca854

fix: typo

cfcf792

Keith-CY reviewed Sep 20, 2023

View reviewed changes

_typos.toml Show resolved Hide resolved

packages/neuron-wallet/src/types/ckbComponents.d.ts Outdated Show resolved Hide resolved

zhangyouxin requested a review from homura September 21, 2023 00:05

chore: remove CKBcomponents any type

258f016

devchenyan approved these changes Sep 21, 2023

View reviewed changes

homura reviewed Sep 21, 2023

View reviewed changes

packages/neuron-wallet/src/types/ckbComponents.d.ts Outdated Show resolved Hide resolved

packages/neuron-wallet/src/types/ckbComponents.d.ts Show resolved Hide resolved

Update packages/neuron-wallet/src/types/ckbComponents.d.ts

add80e7

Co-authored-by: Yonghui Lin <[email protected]>

homura reviewed Sep 21, 2023

View reviewed changes

packages/neuron-wallet/src/types/ckbComponents.d.ts Outdated Show resolved Hide resolved

chore: update the type of http/htts agent

3decee3

chore: add @ckb-lumos/toolkit to dep list

22e2823

Revert "chore: add @ckb-lumos/toolkit to dep list"

b08fc0e

This reverts commit 22e2823.

Merge branch 'develop' into refactor-ckb-sdk-core

70ffa8e

zhangyouxin mentioned this pull request Oct 13, 2023

refactor: remove peerDependency of toolkit ckb-js/lumos#560

Merged

2 tasks

zhangyouxin added 3 commits October 13, 2023 15:52

Merge remote-tracking branch 'upstream/develop' into refactor-ckb-sdk…

c7d861b

…-core

Merge remote-tracking branch 'origin/refactor-ckb-sdk-core' into refa…

243e8c2

…ctor-ckb-sdk-core

chore: update lumos version

f83c13c

Keith-CY merged commit f3cc18a into nervosnetwork:develop Oct 20, 2023
10 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor: remove ckb-sdk-core and replace with lumos #2843

refactor: remove ckb-sdk-core and replace with lumos #2843

zhangyouxin commented Sep 18, 2023

silySuper commented Sep 19, 2023 •

edited by github-actions bot

Loading

silySuper commented Sep 19, 2023

zhangyouxin commented Sep 19, 2023

zhangyouxin commented Sep 22, 2023 •

edited by github-actions bot

Loading

silySuper commented Sep 22, 2023

zhangyouxin commented Sep 22, 2023

Keith-CY commented Sep 22, 2023 •

edited

Loading

zhangyouxin commented Sep 22, 2023 •

edited by github-actions bot

Loading

zhangyouxin commented Sep 25, 2023

homura commented Oct 13, 2023

zhangyouxin commented Oct 13, 2023 •

edited by github-actions bot

Loading

silySuper commented Oct 16, 2023 •

edited by github-actions bot

Loading

silySuper commented Oct 20, 2023

refactor: remove ckb-sdk-core and replace with lumos #2843

refactor: remove ckb-sdk-core and replace with lumos #2843

Conversation

zhangyouxin commented Sep 18, 2023

Description

silySuper commented Sep 19, 2023 • edited by github-actions bot Loading

silySuper commented Sep 19, 2023

zhangyouxin commented Sep 19, 2023

zhangyouxin commented Sep 22, 2023 • edited by github-actions bot Loading

silySuper commented Sep 22, 2023

zhangyouxin commented Sep 22, 2023

Keith-CY commented Sep 22, 2023 • edited Loading

zhangyouxin commented Sep 22, 2023 • edited by github-actions bot Loading

zhangyouxin commented Sep 25, 2023

homura commented Oct 13, 2023

zhangyouxin commented Oct 13, 2023 • edited by github-actions bot Loading

silySuper commented Oct 16, 2023 • edited by github-actions bot Loading

silySuper commented Oct 20, 2023

silySuper commented Sep 19, 2023 •

edited by github-actions bot

Loading

zhangyouxin commented Sep 22, 2023 •

edited by github-actions bot

Loading

Keith-CY commented Sep 22, 2023 •

edited

Loading

zhangyouxin commented Sep 22, 2023 •

edited by github-actions bot

Loading

zhangyouxin commented Oct 13, 2023 •

edited by github-actions bot

Loading

silySuper commented Oct 16, 2023 •

edited by github-actions bot

Loading