Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: handle hash_type:data2 #3264

Merged
merged 2 commits into from
Nov 13, 2024
Merged

feat: handle hash_type:data2 #3264

merged 2 commits into from
Nov 13, 2024

Conversation

devchenyan
Copy link
Collaborator

@devchenyan devchenyan commented Nov 12, 2024 •
edited
Loading

target: #3255

@Danie0918
Copy link
Collaborator

@homura @yanguoyu Please have a review.

homura
homura approved these changes Nov 12, 2024
View reviewed changes
Copy link
Collaborator

@homura homura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing of the code LGTM. The feature must be manually verified

@devchenyan devchenyan requested a review from Keith-CY November 12, 2024 08:08
@Keith-CY Keith-CY merged commit 9746c68 into update-ckb-client-versions Nov 13, 2024
21 checks passed
@Keith-CY Keith-CY deleted the feat-data2 branch November 13, 2024 01:56
@Keith-CY Keith-CY mentioned this pull request Nov 13, 2024
Merged
@Keith-CY Keith-CY restored the feat-data2 branch December 13, 2024 03:04
@Keith-CY Keith-CY mentioned this pull request Dec 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yanguoyu yanguoyu yanguoyu approved these changes

@homura homura homura approved these changes

@Keith-CY Keith-CY Keith-CY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@devchenyan @Danie0918 @Keith-CY @homura @yanguoyu