Fix gcc truncate and overflow warnings #2649
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nesbox
requested changes
Aug 11, 2024
|
|
||
| char buf[sizeof "00:00"]; | ||
| char buf[32]; |
There was a problem hiding this comment.
Why do you replaced sizeof "00:00" with 32, we don't need 32 bytes here
| @@ -248,8 +248,8 @@ static void saveOptions(Config* config) | |||
| { | |||
| const struct StudioOptions* options = &config->data.options; | |||
|
|
|||
| string buf; | |||
| sprintf(buf.data, JSON( | |||
| char buf[2048]; | |||
There was a problem hiding this comment.
why do you removed using of string struct and increased it from 1024 to 2048
| @@ -237,7 +237,7 @@ static void drawTileIndex(Map* map, s32 x, s32 y) | |||
|
|
|||
| if(index >= 0) | |||
| { | |||
| char buf[sizeof "#9999"]; | |||
| char buf[16]; | |||
There was a problem hiding this comment.
same here, we don't need 16 bytes here
|
I'll try to improve it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.