Rename Parameter class in Topology to TopologyParameter #408
Conversation
| @@ -24,6 +24,7 @@ | |||
| import nest | |||
| import nest.topology as tp | |||
| import matplotlib.pyplot as plt | |||
| from mpl_toolkits.mplot3d.axes3d import Axes3D | |||
There was a problem hiding this comment.
Is this used somewhere in the file? If it is, why was this import not here before?
There was a problem hiding this comment.
This is required to enable 3d projection here. I am not sure why it was not needed before. That may be due to internal changes in matplotlib.
|
Why did you re-add all the figures? For me they look the same, with only very minor shifts probably due to another version of some font library. Can you please remove them? The code changes are trivial and look good to me. 👍 once the images are gone and my other comment is addressed. |
|
@jougs I committed all the figure files because they were recreated with the modified script and topology code. Incidentally, this fixes #300: Fig 3.6. is now back in the PDF. But I agree that the figures should probably not be committed, just the final manuscript PDF. I will create a new issue for that change. I'd appreciate merging this PR soon, since #352 depends on it. |
|
Agreed. As this is just a simple rename otherwise, I'll merge without second review. |
The renaming is motivated by #352 and the need for a
Parameterclass in NEST. As an extra, it fixes a little detail in the scripts used to build the topology user manual. The main point of renaming in topology is that theParameterclass to be introduced in nestkernel will be the general parameter class for the future.@jakobj @jougs Would you take a look---it is really just renaming.