Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests to examples #3196

Closed
wants to merge 3 commits into from
Closed

Adding tests to examples #3196

wants to merge 3 commits into from

Conversation

TannerGabriel
Copy link

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Other... Please describe: Docs / Samples

What is the current behavior?

Issue Number: #1539

What is the new behavior?

Added unit and e2e test for sql-typeorm sample.

Does this PR introduce a breaking change?

[ ] Yes
[X] No

Other information

@coveralls
Copy link

coveralls commented Oct 16, 2019

Pull Request Test Coverage Report for Build 4755

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.09%) to 95.194%

Files with Coverage Reduction New Missed Lines %
packages/microservices/context/rpc-context-creator.ts 4 92.23%
packages/websockets/context/ws-context-creator.ts 4 92.08%
Totals Coverage Status
Change from base Build 4669: -0.09%
Covered Lines: 4358
Relevant Lines: 4578

💛 - Coveralls

@RodolfoSilva
Copy link

@TannerGabriel @kamilmysliwiec have any updates related to this PR?

@TannerGabriel
Copy link
Author

Sorry, it seems that I completely forgot about this issue. My changes are now useless because the whole example changed but I could write new tests if the interest in testing the examples still exists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants