-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement count query type (RAW|ENTITY) #805
base: master
Are you sure you want to change the base?
Conversation
Will this be merged ? I have same problem with N-N relationships and this package. |
This solution works for me using TypeORM in a Nest.js project with query builder and joins calculating the correct Please review and merge someone with permissions. |
I could also benefit from this change. |
@bashleigh is there a chance You can merge this please? |
@bashleigh Looking forward to this PR being merged |
@bashleigh would also like to get this merged |
Sorry it's been a while. I think I prefer this PR out of all the solutions I've seen. Don't suppose you'd mind adding some docs on the readme on how to use it and then I'd be happy to merge it and release as the next minor version |
Can we expect this PR to be merged? |
Would also like to see this merged too. |
This allows the query builder to choose a count query type which is counts for RAW or counts for ENTITY when an entity has inner join with many to many relations
ref issue #803 #758