Skip to content

Commit

Permalink
feat(PL-2911): configure health probe timeouts
Browse files Browse the repository at this point in the history
  • Loading branch information
davidmdm committed Sep 3, 2024
1 parent 0f10de3 commit 28bd67d
Show file tree
Hide file tree
Showing 8 changed files with 21 additions and 4 deletions.
2 changes: 2 additions & 0 deletions chart/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -88,10 +88,12 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: {{ .Values.probes.timeoutSeconds }}
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: {{ .Values.probes.timeoutSeconds }}
resources:
{{- toYaml .Values.resources | nindent 12 }}
{{- with .Values.nodeSelector }}
Expand Down
2 changes: 2 additions & 0 deletions chart/tests/with-additional-labels/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,11 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: 1
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: 1
resources:
{}
2 changes: 2 additions & 0 deletions chart/tests/with-credentials/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,11 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: 1
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: 1
resources:
{}
2 changes: 2 additions & 0 deletions chart/tests/with-github-app-and-sealed-secrets/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,12 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: 1
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: 1
resources:
{}
---
Expand Down
2 changes: 2 additions & 0 deletions chart/tests/with-github-app/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,11 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: 1
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: 1
resources:
{}
2 changes: 2 additions & 0 deletions chart/tests/with-github-token/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -99,9 +99,11 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: 1
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: 1
resources:
{}
2 changes: 2 additions & 0 deletions chart/tests/with-request-timeout/expected.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,9 +110,11 @@ spec:
httpGet:
path: /api/v1/health
port: http
timeoutSeconds: 1
readinessProbe:
httpGet:
path: /api/v1/readiness
port: http
timeoutSeconds: 1
resources:
{}
11 changes: 7 additions & 4 deletions chart/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ secretEnv:
# PLUGIN_TOKEN: ""
# GH_TOKEN: ""

githubAppPrivateKey: ""
githubAppPrivateKey: ''

# Additional annotations for sealed secrets
sealedSecretAnnotations: {}
Expand All @@ -33,11 +33,14 @@ image:
repository: ghcr.io/nestoca/joy-generator
pullPolicy: IfNotPresent
# Overrides the image tag whose default is the chart appVersion.
tag: ""
tag: ''

probes:
timeoutSeconds: 1

imagePullSecrets: []
nameOverride: ""
fullnameOverride: ""
nameOverride: ''
fullnameOverride: ''

podAnnotations: {}

Expand Down

0 comments on commit 28bd67d

Please sign in to comment.