Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat/PL 2554/support chart refs #12

Merged
merged 3 commits into from
Mar 21, 2024
Merged

feat/PL 2554/support chart refs #12

merged 3 commits into from
Mar 21, 2024

Conversation

davidmdm
Copy link
Contributor

silphid
silphid approved these changes Mar 20, 2024
View reviewed changes
Copy link

@silphid silphid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm trusting you on this one, because I really master neither gin nor the generator logic... Beyond integration tests made outside of ArgoCD's context, did you intend to test it for real only at time of deployment?

cmd/server/config.go Outdated Show resolved Hide resolved
cmd/server/handler.go Show resolved Hide resolved
@davidmdm davidmdm force-pushed the feat/PL-2554/support-chart-refs branch 3 times, most recently from 8ae2eed to ed3ddd5 Compare March 20, 2024 18:09
@davidmdm davidmdm force-pushed the feat/PL-2554/support-chart-refs branch 2 times, most recently from eb05b9c to 052bc84 Compare March 20, 2024 18:46
@davidmdm davidmdm force-pushed the feat/PL-2554/support-chart-refs branch 4 times, most recently from b99462e to c369103 Compare March 21, 2024 16:29
silphid
silphid approved these changes Mar 21, 2024
View reviewed changes
Copy link

@silphid silphid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, there's just the 0.4.0 chart version in test expectations that I don't understand why it's not 1.0.0 or some predictable value.

@davidmdm davidmdm force-pushed the feat/PL-2554/support-chart-refs branch 2 times, most recently from f1f80fe to ed57a22 Compare March 21, 2024 16:40
@davidmdm davidmdm force-pushed the feat/PL-2554/support-chart-refs branch from ed57a22 to 4415048 Compare March 21, 2024 17:06
@davidmdm davidmdm merged commit a36a8a1 into master Mar 21, 2024
4 checks passed
@davidmdm davidmdm deleted the feat/PL-2554/support-chart-refs branch March 21, 2024 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silphid silphid silphid approved these changes

@ayahajar ayahajar Awaiting requested review from ayahajar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@davidmdm @silphid