fix: add datadog service label value to chart #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexstojda
reviewed
May 10, 2024
| image: | ||
| tag: 0.1.2 | ||
|
|
||
| datadogServiceLabel: joy-generator-chart-test |
There was a problem hiding this comment.
this is a bit opinionated on having datadog.
I would go with a more generic approach of having an additionalLabels or, more specifically a podLabels field which is a map of labels & values. This is the approach most charts use.
alexstojda
reviewed
May 10, 2024
chart/templates/_helpers.tpl
Outdated
| @@ -34,6 +34,7 @@ Create chart name and version as used by the chart label. | |||
| Common labels | |||
| */}} | |||
| {{- define "joy-generator.labels" -}} | |||
| tags.datadoghq.com/service: {{ .Values.datadogServiceLabel | default .Chart.Name }} | |||
There was a problem hiding this comment.
Suggested change
| tags.datadoghq.com/service: {{ .Values.datadogServiceLabel | default .Chart.Name }} | |
| tags.datadoghq.com/service: {{ .Values.datadogServiceLabel | default .Release.Name }} |
What do you think about using the release name here instead?
davidmdm
force-pushed
the
fix/add-datadog-service-label
branch
3 times, most recently
from
59d0ef9
to
14a0adc
Compare
alexstojda
reviewed
May 10, 2024
chart/templates/_helpers.tpl
Outdated
Comment on lines
43
to
45
| {{- if .Values.podLabels }} | ||
| {{ toYaml .Values.podLabels }} | ||
| {{- end -}} |
There was a problem hiding this comment.
Check your expected file, the labels here are not added to the pod, only the meta of resources. In other words the labels were added to the deployment, but not the pod template.
This block should go below this line
davidmdm
force-pushed
the
fix/add-datadog-service-label
branch
from
14a0adc
to
8c43091
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.