fix(PL-660): validate crd schemas against file content not deserialized representation #194
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too long ago, schemas were added to represent the Joy CRDs. However the original implementation was wrong in that it would validate against the already serialized Go struct instead of the files root yaml node.
This would cause information loss and things to not get picked up by the schema validation.
For example with this change the internal tests started failing because
versionKey
which is an unknown property was being caught and it previously was not.This has since been fixed in this commit.