feat(PL-2834): support mappings per chart and release #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmdm
force-pushed
the
feat/PL-2834/support-mappings-per-chart-and-release
branch
from
6c78b3e
to
683facb
Compare
davidmdm
requested review from
alexstojda,
silphid,
j-martin and
ayahajar
as code owners
alexstojda
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR allows mappings to be configured per chart both at the reference level within the catalog's joy.yaml configuration and within the release.
This will allow us to move the
image.tagmapping from the global configuration to being specific to thegenericchart. It will allow us to map our application version to different mappings for different charts.This feature replaces the intent of
versionKeythat was broken but used in the appset.