refactor(PL-2848): Remove all usage of Jac #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
alexstojda
commented
Aug 23, 2024
alexstojda
commented
- This is a breaking change, but we haven't agreed on when to release v1 of the cli, so its not marked as such.
- This is a breaking change, but we haven't agreed on when to release v1 of the cli, so its not marked as such.
alexstojda
requested review from
silphid,
j-martin,
davidmdm and
ayahajar
as code owners
j-martin
approved these changes
Aug 23, 2024
| @@ -60,7 +60,7 @@ package v1alpha1 | |||
| metadata!: #metadata | |||
| spec: { | |||
| // Owners is the list of identifiers of owners of the project. | |||
| // It can be any string that uniquely identifies the owners, such as email addresses or Jac group identifiers. | |||
| // It can be any string that uniquely identifies the owners, such as email addresses or backstage group names | |||
There was a problem hiding this comment.
Is the plan to wait for backstage to be available before merging this?
There was a problem hiding this comment.
Nope, the field is now an array of arbitrary strings, there is no actual connection to backstage, its really just a "suggested use".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.