Skip to content

Conversation

shashidhar184
Copy link
Contributor

@shashidhar184 shashidhar184 commented Oct 4, 2025

Related Issue(s)

Proposed Changes

Cisco IOS-XR Version

24.4.2

Checklist

Test, validate and ensure pre-commit is run before submitting PR

  • Latest commit is rebased from main/master with merge conflicts resolved
  • All pre-commit hooks passed

@rwcrowe rwcrowe self-requested a review October 11, 2025 19:52
pcc_initiated_orphan = try(local.device_config[device.name].segment_routing_te.pcc_initiated_orphan, local.defaults.iosxr.configuration.segment_routing_te.pcc_initiated_orphan, null)

pce_peers = [
for peer in try(local.device_config[device.name].segment_routing_te.pce_peers, local.defaults.iosxr.configuration.segment_routing_te.pce_peers, []) : {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • You can take device defaults out of list itself. local.defaults.iosxr.configuration.segment_routing_te.on_demand_colors, . Same for the rest of the lists below.


pce_peers = [
for peer in try(local.device_config[device.name].segment_routing_te.pce_peers, local.defaults.iosxr.configuration.segment_routing_te.pce_peers, []) : {
pce_address = try(peer.pce_address, null)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add devices defaults for each attribute. Same for the rest of the list attributes.

for device in local.devices : [
{
device_name = device.name
key = "${device.name}-segment-routing-te"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Can you change key to just device name since this is a singleton resource.
    key = device.name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants