[management] Add idp timeout env variable #4647
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ressys1978
changed the title
… recorder is not available (netbirdio#4652)
|
@mlsmaycon how does one get this reviewed? |
mlsmaycon
requested changes
Oct 23, 2025
management/server/idp/util.go
Outdated
| return defaultTimeout | ||
| } | ||
|
|
||
| timeoutInt, err := strconv.Atoi(timeoutStr) |
There was a problem hiding this comment.
Let's use time.ParseDuration("10s") so match other conversations we have in the system
There was a problem hiding this comment.
@mlsmaycon I've made the requested change.
|
@bcmmbaga can you have a look? |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Introduced the NETBIRD_IDP_TIMEOUT environment variable to the management service. This allows configuring a timeout for supported IDPs. If the variable is unset or contains an invalid value, a default timeout of 10 seconds is used as a fallback.
This is needed for larger IDP environments where 10s is just not enough time.
Issue ticket number and link
This should fix #1386
Stack
Checklist
Documentation
Select exactly one:
I don't feel this needs to be documented at this time, as currently the number of self-hosted netbird users with larger IDP environments is probably very small.
Docs PR URL (required if "docs added" is checked)
Paste the PR link from https://github.com/netbirdio/docs here:
https://github.com/netbirdio/docs/pull/__