Skip to content

Conversation

@lixmal
Copy link
Collaborator

@lixmal lixmal commented Oct 26, 2025

Describe your changes

Issue ticket number and link

Stack

Checklist

  • Is it a bug fix
  • Is a typo/documentation fix
  • Is a feature enhancement
  • It is a refactor
  • Created tests that fail without the change (if possible)

By submitting this pull request, you confirm that you have read and agree to the terms of the Contributor License Agreement.

Documentation

Select exactly one:

  • I added/updated documentation for this change
  • Documentation is not needed for this change (explain why)

Docs PR URL (required if "docs added" is checked)

Paste the PR link from https://github.com/netbirdio/docs here:

https://github.com/netbirdio/docs/pull/__

Copilot AI review requested due to automatic review settings October 26, 2025 14:23
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds CPU profiling capability to the debug bundle by implementing RPC methods to start and stop profiling in the daemon, capturing the profile data during debug bundle collection.

  • Adds StartCPUProfile and StopCPUProfile RPC methods to the daemon service
  • Integrates CPU profiling into the debug bundle generation workflow
  • Captures profiling data during the debug bundle collection window

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
client/proto/daemon.proto Defines new RPC methods and message types for CPU profiling
client/proto/daemon.pb.go Generated protobuf code for CPU profiling messages
client/proto/daemon_grpc.pb.go Generated gRPC client/server code for CPU profiling methods
client/server/server.go Adds fields to track CPU profiling state and buffer
client/server/debug.go Implements StartCPUProfile and StopCPUProfile RPC handlers
client/internal/debug/debug.go Integrates CPU profile data into debug bundle archive
client/ui/debug.go Starts CPU profiling before collecting debug data
client/cmd/debug.go Adds CPU profiling lifecycle management to CLI debug command

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants