Skip to content

[Client] cleanup leftover dns and nrpt policies on windows #4710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[Client] cleanup leftover dns and nrpt policies on windows #4710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions client/installer.nsis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,28 @@ ExecWait `taskkill /im ${UI_APP_EXE}.exe /f`
DetailPrint "Removing autostart registry entry if exists..."
DeleteRegValue HKCU "${AUTOSTART_REG_KEY}" "${APP_NAME}"

; Clean up DNS policies/NRPT entries
DetailPrint "Cleaning up DNS policies and NRPT entries..."
nsExec::ExecToLog 'powershell.exe -NoProfile -WindowStyle Hidden -ExecutionPolicy Bypass -Command "& {
$basePath = \"HKLM:\\SYSTEM\\CurrentControlSet\\Services\\Dnscache\\Parameters\\DnsPolicyConfig\";
if (Test-Path $basePath) {
$keys = Get-ChildItem -Path $basePath -ErrorAction SilentlyContinue | Where-Object { $_.PSChildName -match \"^(?i)netbird\" };
if ($keys) {
foreach ($key in $keys) {
Write-Host \"Removing NRPT key: $($key.PSChildName)\" -ForegroundColor Yellow;
try { Remove-Item -Path $key.PSPath -Recurse -Force -ErrorAction Stop }
catch { Write-Warning \"Failed to remove $($key.PSChildName): $_\" }
}
Write-Host \"All matching Netbird keys removed. Restarting DNS Client service...\" -ForegroundColor Green;
Restart-Service Dnscache -Force
} else {
Write-Host \"No Netbird-related keys found.\" -ForegroundColor Cyan
}
} else {
Write-Warning \"DnsPolicyConfig path not found. Nothing to remove.\"
}
}"'

; Handle data deletion based on checkbox
DetailPrint "Checking if user requested data deletion..."
${If} $DeleteDataEnabled == "1"
Expand Down
Loading