Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added primary_ip4_netmask to output #1293

Open
wants to merge 3 commits into
base: devel
Choose a base branch
from

Conversation

rooso
Copy link

@rooso rooso commented Jul 30, 2024

Related Issue

#931

New Behavior

nb_inventory plugin returns netmask if primary ip4 address is linked to virtual machine:

"primary_ip4": "192.168.0.1"
"primary_ip4_netmask": "255.255.255.0"

Contrast to Current Behavior

nb_inventory plugin returns only the primary_ip4:

"primary_ip4": "192.168.0.1"

Discussion: Benefits and Drawbacks

Useful if netbox is used as source for the ip addresses to create virtual machines using ansible.
There are now drawbacks of this change as it is just a attribute that is passed along with the inventory if a primary_ip4 is linked to a virtual machine.

Changes to the Documentation

no update needed

Proposed Release Note Entry

Adds the ability to return primary_ip4_netmask for virtual machines in nb_inventory plugin

Double Check

  • I have read the comments and followed the CONTRIBUTING.md.
  • I have explained my PR according to the information in the comments or in a linked issue.
  • My PR targets the devel branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant