fix issue 1479 - netbox_service - More than one result returned for #1484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cernymi
force-pushed
the
cernymi/fix-issue-1479
branch
from
f7c1398 to
47a3c14
Compare
- allow compare even 3 digit versions or more - sanitize inputs - full_version can sometimes be 4.2.9-Docker-3.2.1 just use only 4.2.9
- allow compare even 3 digit versions or more - sanitize inputs - full_version can sometimes be 4.2.9-Docker-3.2.1 just use only 4.2.9
- elif parent == "services":
is workaround for Netbox 4.3.0 - 4.4.3 - #20554
GET Parent_object_type wrong data type - integer instead of string
Just delete parent_object_type and parent_object_id
GET is broken anyway
- netbox-version can sometimes be 4.2.9-Docker-3.2.1 but expecting full_version is just 4.2.9 do not see any purpose Docker-3.2.1
cernymi
force-pushed
the
cernymi/fix-issue-1479
branch
from
47a3c14 to
5a4514c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Issue #1479
(and PR #1427 seems missing ALLOWED_QUERY_PARAMS part)
Modified Behavior
add
parent_object_typeandparent_object_idtoservicesALLOWED_QUERY_PARAMSadd workaround to
_build_query_paramsfor services and Netbox 4.3.0 - 4.4.3ipam/services: GET parent_object_type - wrong data type - integer netbox#20554
sanitized
full_versionin netbox_utilsadded
_version_less_thanto netbox_utilsimproved
_version_check_greaterin netbox_utilsadded
yamllintand errors fixesNew Behavior
None
...
Contrast to Current Behavior
You'll be able to create more services with the same name but different parent. For netbox 4.4.4 and never
Parent param introduced in Netbox 4.3.0
...
Discussion: Benefits and Drawbacks
Services will work correctly again for Netbox 4.4.4 (4.3.0) and never
parent_object_typeandparent_object_idshould be added toservicesALLOWED_QUERY_PARAMS...
Changes to the Documentation
None
...
Proposed Release Note Entry
Fix netbox_services for Netbox 4.3.0 and never
...
Double Check
develbranch.