Fix: add logic to update site of prefix in netbox #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruelea
force-pushed
the
fix/add-site-to-resource-in-netbox
branch
from
7568285
to
06d0221
Compare
henrybear327
force-pushed
the
fix/add-site-to-resource-in-netbox
branch
from
06d0221
to
cca5ea8
Compare
bruelea
force-pushed
the
fix/add-site-to-resource-in-netbox
branch
from
cca5ea8
to
b82870c
Compare
henrybear327
approved these changes
Nov 10, 2024
henrybear327
force-pushed
the
fix/add-site-to-resource-in-netbox
branch
from
b82870c
to
27973d4
Compare
henrybear327
force-pushed
the
fix/add-site-to-resource-in-netbox
branch
from
27973d4
to
f521fd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the site that is set in a prefixclaim CR is not updated in NetBox. This PR focuses on fixing the underlying logic to ensure accurate updates.
Using the go-netbox client the site is not removed from the resource in NetBox with the IpamPrefixesUpdate function. To avoid inconsistent state between the Prefix CR and the Prefix Resource in NetBox a validation rule was added to the prefix type which does not allow the deletion of the site field once it was created.