-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
4867 multiple mac addresses #17902
Open
bctiemann
wants to merge
54
commits into
feature
Choose a base branch
from
4867-multiple-mac-addresses
base: feature
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
4867 multiple mac addresses #17902
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ed because of inheritance from ComponentBulkEditForm)
jeremystretch
requested changes
Nov 8, 2024
…ne already exists for the interface
…Components" and related groupings
jeremystretch
requested changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #17902
This PR changes the
mac_address
of an Interface or VMInterface from a simple model field to a many-to-one relationship with a newMACAddress
model. This allows many MAC addresses to be associated with a single Interface or VMInterface (with one optionally designatedis_primary
).The "MAC Addresses" pageset is grouped under Devices -> Device Components.
Interfaces and VMInterfaces now show an inline table for creation of associated MACAddress objects:
There is a data migration which converts existing
mac_address
values to concreteMACAddress
objects. There is also now amac_address
property on bothInterface
andVMInterface
which reflects the value of the primary (or only)MACAddress
associated with the interface, preserving backward compatibility for querying and display.Filtering by
mac_address
works as before, acting on the related object'smac_address
field.Note: bulk create of Interfaces and VMInterfaces via POST will create associated MACAddress objects; but bulk edit of those same objects with
mac_address
specified in the payload is not supported. This is consistent with preexisting unit test coverage of bulk create and edit operations intest_views.py
modules; however this is an area for potential future refinement.