-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
17929 Add Scope Mixins to Prefix #17930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arthanson
changed the title
DRAFT: 17929 Add Scope Mixins to Prefix
17929 Add Scope Mixins to Prefix
Nov 7, 2024
IMO this is going to cause problems in the future, as we're forcing ourselves to accommodate what is essentially a typo. I propose adopting one of three options:
|
jeremystretch
requested changes
Nov 14, 2024
jeremystretch
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #17929
Had to move the filterset mixin to it's own file as there was a circular dependency - this requires updating previous imports that reference it.
Note: The mixin uses %(class)s for the related_name which resolves to "_prefixs" instead of "_prefixes" which isn't great, but it is an internal field that shouldn't really be references, so shouldn't be much of an issue.