Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #11279: Replace _name natural key sorting with collation #18009

Merged
merged 10 commits into from
Nov 15, 2024

Conversation

arthanson
Copy link
Collaborator

@arthanson arthanson commented Nov 13, 2024

Fixes: #11279

  • Interface uses naturalize_interface so needed to keep _name on it, same for VMInterface
  • utilities.ordering.naturalize does not look like it is used anymore but is used in migrations so can't be removed currently - we could backport changes to old migrations and remove it if wanted.

See the screenshot for sorting - accented / umlaut characters are handled better then before and look to be in the correct ordering.
Sites | NetBox 2024-11-13 13-00-08

@arthanson arthanson changed the base branch from develop to feature November 13, 2024 19:08
@arthanson arthanson marked this pull request as ready for review November 13, 2024 22:10
@jeremystretch jeremystretch added this to the v4.2 milestone Nov 14, 2024
@jeremystretch jeremystretch changed the title DRAFT: 11279 Replace _name natural key sorting with collation Closes #11279: Replace _name natural key sorting with collation Nov 14, 2024
netbox/dcim/migrations/0197_natural_sort.py Outdated Show resolved Hide resolved
netbox/dcim/tables/devicetypes.py Show resolved Hide resolved
netbox/virtualization/models/virtualmachines.py Outdated Show resolved Hide resolved
netbox/utilities/fields.py Outdated Show resolved Hide resolved
netbox/virtualization/models/virtualmachines.py Outdated Show resolved Hide resolved
netbox/dcim/views.py Outdated Show resolved Hide resolved
@jeremystretch jeremystretch merged commit 6ab0792 into feature Nov 15, 2024
6 checks passed
@jeremystretch jeremystretch deleted the 11279-natural-key branch November 15, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the use of natural ordering to additional models
2 participants