Fixes: #16757 - Use table_htmx.html for assigning ipaddresses #18226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremystretch
requested changes
Dec 16, 2024
…t flow to avoid htmx fragmentary rendering on object save
|
@jeremystretch Turns out that behavior you're seeing of the subsequent table rendering is happening in develop, it's not related to my fix. I've added another adjustment which lets us |
…ssignment flow to avoid htmx fragmentary rendering on object save" This reverts commit fa8f2ac.
|
Reverted the last commit as the full-page bare-view issue is preexisting and beyond the scope of this specific issue's fix. |
jeremystretch
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #16757
Swaps
inc/table_htmx.htmlforinc/table.htmlin theipaddress_assign.htmltemplate. This ensures that objects clicked on in that table return a properly targeted HTMX response, whether or not HTMX navigation is turned on.There are many places where
inc/table.htmlis used, but it appears HTMX targeting is not used in those places. As HTMX is rolled out more pervasively, these will all need to be audited.