fix: proper check napalm community driver packages (#17)

diode-napalm-agent/diode_napalm/discovery.py

@@ -28,11 +28,10 @@ def napalm_driver_list() -> list[str]:
 
     """
     napalm_packages = ["ios", "eos", "junos", "nxos"]
-    prefix = "napalm-"
-    for dist in importlib_metadata.distributions():
-        if dist.metadata["Name"].startswith(prefix):
-            package = dist.metadata["Name"][len(prefix) :].replace("-", "_")
-            napalm_packages.append(package)
+    prefix = "napalm_"
+    for dist in importlib_metadata.packages_distributions():
+        if dist.startswith(prefix):
+            napalm_packages.append(dist[len(prefix) :])
     return napalm_packages
 
 

diode-napalm-agent/tests/test_discovery.py

@@ -24,9 +24,11 @@ def mock_get_network_driver():
 
 
 @pytest.fixture
-def mock_importlib_metadata_distributions():
-    """Mock the importlib_metadata.distributions function."""
-    with patch("diode_napalm.discovery.importlib_metadata.distributions") as mock:
+def mock_importlib_metadata_packages_distributions():
+    """Mock the importlib_metadata.packages_distributions function."""
+    with patch(
+        "diode_napalm.discovery.importlib_metadata.packages_distributions"
+    ) as mock:
         yield mock
 
 
@@ -148,20 +150,20 @@ def side_effect(driver_name):
     assert driver == "nxos", "Expected the 'ios' driver to be found"
 
 
-def test_napalm_driver_list(mock_importlib_metadata_distributions):
+def test_napalm_driver_list(mock_importlib_metadata_packages_distributions):
     """
     Test the napalm_driver_list function to ensure it correctly lists available NAPALM drivers.
 
     Args:
     ----
-        mock_importlib_metadata_distributions: Mocked importlib_metadata.distributions function.
+        mock_importlib_metadata_packages_distributions: Mocked importlib_metadata.packages_distributions function.
 
     """
     mock_distributions = [
-        MagicMock(metadata={"Name": "napalm-srl"}),
-        MagicMock(metadata={"Name": "napalm-fake-driver"}),
+        "napalm_srl",
+        "napalm_fake_driver",
     ]
-    mock_importlib_metadata_distributions.return_value = mock_distributions
+    mock_importlib_metadata_packages_distributions.return_value = mock_distributions
     expected_drivers = ["ios", "eos", "junos", "nxos", "srl", "fake_driver"]
     drivers = napalm_driver_list()
     assert drivers == expected_drivers, f"Expected {expected_drivers}, got {drivers}"