Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support devices that do not implement get_vlans #7

Closed
wants to merge 1 commit into from
Closed

Support devices that do not implement get_vlans #7

wants to merge 1 commit into from

Conversation

jbemmel
Copy link

@jbemmel jbemmel commented Jul 23, 2024

For example the Nokia napalm-sros driver does not implement get_vlans, this should not prohibit discovery of such devices

@leoparente leoparente mentioned this pull request Jul 29, 2024
Merged
@leoparente
Copy link
Collaborator

Hi @jbemmel, thanks for your PR. However, we will address it in a different form for now by removing this call (see #11). But in the future, when we start supporting vlan fetch and ingestion, we will take in to count your finding! For now, I will close this PR.

@leoparente leoparente closed this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente Awaiting requested review from leoparente leoparente is a code owner

@mfiedorowicz mfiedorowicz Awaiting requested review from mfiedorowicz mfiedorowicz is a code owner

@natm natm Awaiting requested review from natm natm is a code owner

Assignees
No one assigned
Labels
python
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jbemmel @leoparente