Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

87 deactivate the current branch when creating a new one #185

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

87 deactivate the current branch when creating a new one #185

wants to merge 1 commit into from

Conversation

arthanson
Copy link
Contributor

Fixes: #87

I wasn't sure if this was overkill, it looks like we could just always switch the root branch when modifying but wanted to keep this just for creation.

@arthanson arthanson marked this pull request as ready for review December 3, 2024 23:36
jeremystretch
jeremystretch requested changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@jeremystretch jeremystretch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry about silently deactivating the branch, as it may be confusing to the user. IMO we should log a message to the user indicating that the branch has been deactivated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremystretch jeremystretch jeremystretch requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The current branch (if any) should be deactivated when attempting to create a new branch
2 participants
@arthanson @jeremystretch