Skip to content

working with selectorplus MCP #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

automateyournetwork
Copy link

  • Added a Dockerfile
  • Allows for NetBox MCP Server to run as a stdio container
  • Updates to the server.py
    • added discovery capabilities - others can now run tools/discover
    • tools/call
  • Added some handling of URLs

Happy to meet and discuss !

@arthanson
Copy link
Contributor

@automateyournetwork there is a lot going on in these changes, can you please split them out into separate PRs with the reasoning behind each? For example it looks like you have deleted the arguments description:

   DCIM (Device and Infrastructure):
     - cables
     - console-ports
     - console-server-ports  

and not sure why that change was made. I think adding a Dockerfile can be a separate PR, and the Allows for NetBox MCP Server to run as a stdio container can be completely separate, etc..

This makes it much easier to review and verify the PR and keeps the changes isolated.

Copy link
Contributor

@arthanson arthanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see previous comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants