wxGUI/psmap: fix show correct error message if Ghostscript isn't inst…

…alled (OSGeo#2420) If Ghostscript (required for rendering output PDF file) isn't installed on the OS MS Windows platform show correct error message.
neteler · Sep 28, 2023 · c0bf403 · c0bf403
1 parent b989e81
commit c0bf403
Show file tree

Hide file tree

Showing 2 changed files with 31 additions and 9 deletions.
diff --git a/gui/wxpython/psmap/frame.py b/gui/wxpython/psmap/frame.py
@@ -407,8 +407,14 @@ def OnCmdDone(self, event):
 
         if event.userData["pdfname"]:
             if sys.platform == "win32":
+                import platform
+
+                arch = platform.architecture()[0]
+                pdf_rendering_prog = "gswin64c"
+                if "32" in arch:
+                    pdf_rendering_prog = "gswin32c"
                 command = [
-                    "gswin32c",
+                    pdf_rendering_prog,
                     "-P-",
                     "-dSAFER",
                     "-dCompatibilityLevel=1.4",
@@ -430,14 +436,23 @@ def OnCmdDone(self, event):
                     "-f",
                     event.userData["filename"],
                 ]
+                title = _("Program {} is not available.").format(pdf_rendering_prog)
+                message = _("{title} Please install it to create PDF.\n\n").format(
+                    title=title
+                )
             else:
+                pdf_rendering_prog = "ps2pdf"
                 command = [
-                    "ps2pdf",
+                    pdf_rendering_prog,
                     "-dPDFSETTINGS=/prepress",
                     "-r1200",
                     event.userData["filename"],
                     event.userData["pdfname"],
                 ]
+                message = _(
+                    "Program {} is not available."
+                    " Please install it to create PDF.\n\n "
+                ).format(pdf_rendering_prog)
             try:
                 proc = grass.Popen(command)
                 ret = proc.wait()
@@ -450,13 +465,20 @@ def OnCmdDone(self, event):
                 else:
                     self.SetStatusText(_("PDF generated"), 0)
             except OSError as e:
-                GError(
-                    parent=self,
-                    message=_(
-                        "Program ps2pdf is not available. Please install it to create PDF.\n\n %s"
+                if sys.platform == "win32":
+                    dlg = HyperlinkDialog(
+                        self,
+                        title=title,
+                        message=message + str(e),
+                        hyperlink="https://www.ghostscript.com/releases/gsdnld.html",
+                        hyperlinkLabel=_("You can download {} version here.").format(
+                            arch
+                        ),
                     )
-                    % e,
-                )
+                    dlg.ShowModal()
+                    dlg.Destroy()
+                    return
+                GError(parent=self, message=message + str(e))
 
         elif not event.userData["temp"]:
             self.SetStatusText(_("PostScript file generated"), 0)

diff --git a/gui/wxpython/psmap/g.gui.psmap.html b/gui/wxpython/psmap/g.gui.psmap.html
@@ -196,7 +196,7 @@ <h3>CARTOGRAPHIC COMPOSER TOOLBAR</h3>
   <dd> Generates hardcopy map output in PostScript/EPS file.</dd>
    <dt><img src="icons/pdf-export.png" alt="icon">&nbsp;
     <em>Generate hardcopy map output in PDF</em></dt>
-  <dd> Generates hardcopy map output in PDF using ps2pdf.</dd>
+  <dd> Generates hardcopy map output in PDF using ps2pdf or <a href="https://www.ghostscript.com/releases/gsdnld.html">Ghostscript gswin32c/gswin64c</a> (OS MS Windows platform only).</dd>
 
 </dl>