style: Fix yoda-conditions (SIM300) (OSGeo#4044)

gui/wxpython/core/gcmd.py

@@ -201,7 +201,7 @@ def kill(self):
             import win32api
 
             handle = win32api.OpenProcess(1, 0, self.pid)
-            return 0 != win32api.TerminateProcess(handle, 0)
+            return win32api.TerminateProcess(handle, 0) != 0
         else:
             try:
                 os.kill(-self.pid, signal.SIGTERM)  # kill whole group

gui/wxpython/core/utils.py

@@ -100,7 +100,7 @@ def GetLayerNameFromCmd(dcmd, fullyQualified=False, param=None, layerType=None):
     if len(dcmd) < 1:
         return mapname, False
 
-    if "d.grid" == dcmd[0]:
+    if dcmd[0] == "d.grid":
         mapname = "grid"
     elif "d.geodesic" in dcmd[0]:
         mapname = "geodesic"

gui/wxpython/iclass/frame.py

@@ -857,8 +857,9 @@ def ExportAreas(self, vectorName, withTable):
                     % {"band": i + 1, "stat": statistic, "format": format}
                 )
 
-        if 0 != RunCommand(
-            "v.db.addtable", map=vectorName, columns=columns, parent=self
+        if (
+            RunCommand("v.db.addtable", map=vectorName, columns=columns, parent=self)
+            != 0
         ):
             wx.EndBusyCursor()
             return False
@@ -1305,10 +1306,10 @@ def CheckInput(self, group, vector):
         rasterInfo = gs.raster_info(groupLayers[0])
 
         if (
-            regionBox.N > rasterInfo["north"]
-            or regionBox.S < rasterInfo["south"]
-            or regionBox.E > rasterInfo["east"]
-            or regionBox.W < rasterInfo["west"]
+            rasterInfo["north"] < regionBox.N
+            or rasterInfo["south"] > regionBox.S
+            or rasterInfo["east"] < regionBox.E
+            or rasterInfo["west"] > regionBox.W
         ):
             GMessage(
                 parent=self,

gui/wxpython/lmgr/layertree.py

@@ -1093,7 +1093,7 @@ def OnCopyMap(self, event):
                 return
 
         kwargs = {key: "%s,%s" % (lnameSrc, lnameDst)}
-        if 0 != RunCommand("g.copy", overwrite=True, **kwargs):
+        if RunCommand("g.copy", overwrite=True, **kwargs) != 0:
             GError(_("Unable to make copy of <%s>") % lnameSrc, parent=self)
             return
 

gui/wxpython/web_services/widgets.py

@@ -662,7 +662,7 @@ def UpdateWidgetsByCmd(self, cmd):
 
         if "bgcolor" in dcmd and self.params["bgcolor"]:
             bgcolor = dcmd["bgcolor"].strip().lower()
-            if len(bgcolor) == 8 and "0x" == bgcolor[:2]:
+            if len(bgcolor) == 8 and bgcolor[:2] == "0x":
                 colour = "#" + bgcolor[2:]
                 self.params["bgcolor"].SetColour(colour)
 

pyproject.toml

@@ -290,7 +290,6 @@ ignore = [
     "SIM118",  # in-dict-keys
     "SIM201",  # negate-equal-op
     "SIM223",  # expr-and-false
-    "SIM300",  # yoda-conditions
     "SIM401",  # if-else-block-instead-of-dict-get
     "SLF001",  # private-member-access
     "TRY002",  # raise-vanilla-class