Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for new dynamic folder mode parameter on Cloudinary #110

Merged
merged 13 commits into from
Nov 28, 2024

Conversation

RandyCupic
Copy link
Member

@RandyCupic RandyCupic commented Sep 5, 2024

This PR introduces support for new dynamic folder_mode configuration that Cloudinary introduced (and is forcing on all new accounts), while still keeping support for the old fixed mode for projects that are currently using it. This can be configured:

netgen_remote_media:
    cloudinary:
        folder_mode: dynamic

Also this PR depends on it's parent PR (upgrading Cloudinary PHP API library form v1 to v2) because folder mode is not supported in v1.

TODO:

  • properly test everything

@RandyCupic RandyCupic force-pushed the upgrade-cloudinary-php-api branch from 5744520 to 66e4b7c Compare September 11, 2024 18:40
@RandyCupic RandyCupic force-pushed the upgrade-cloudinary-php-api branch from 5da99ef to 534a2f0 Compare September 19, 2024 16:13
@RandyCupic RandyCupic changed the title [WIP] Add support for new dynamic folder mode parameter on Cloudinary Add support for new dynamic folder mode parameter on Cloudinary Sep 19, 2024
@RandyCupic RandyCupic requested a review from iherak September 20, 2024 08:00
Base automatically changed from upgrade-cloudinary-php-api to 3.0 November 28, 2024 10:44
@RandyCupic RandyCupic merged commit 20a85b7 into 3.0 Nov 28, 2024
6 checks passed
@RandyCupic RandyCupic deleted the feature/folder-mode branch November 28, 2024 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant