Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: change container name and default branch #6

Merged
merged 2 commits into from
Dec 22, 2023
Merged

chore: change container name and default branch #6

merged 2 commits into from
Dec 22, 2023

Conversation

andre8244
Copy link
Collaborator

  • Change container name
  • Change branch name for storybook workflow (now default branch is main)

@andre8244 andre8244 requested a review from Tbaile December 21, 2023 12:07
Tbaile
Tbaile approved these changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@Tbaile Tbaile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely this escaped my sed, unfortunate

@Tbaile Tbaile self-requested a review December 22, 2023 08:00
Tbaile
Tbaile requested changes Dec 22, 2023
View reviewed changes
Copy link
Collaborator

@Tbaile Tbaile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Due to how changelog is handled, I'd advice to use build context for the commit that changes the name of container and ci for the one that changes the workflow branch

Anything else will most likely end up in the changelog, which is pretty confusing

@andre8244 andre8244 force-pushed the change-container-name branch from f593ee0 to 1de0649 Compare December 22, 2023 08:30
@andre8244 andre8244 requested a review from Tbaile December 22, 2023 08:30
@Tbaile Tbaile merged commit 439f842 into main Dec 22, 2023
@Tbaile Tbaile deleted the change-container-name branch December 22, 2023 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tbaile Tbaile Awaiting requested review from Tbaile

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andre8244 @Tbaile