fix!: enforcing types on parent projects #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tbaile
added a commit
to NethServer/nethsecurity-ui
that referenced
this pull request
Nov 7, 2024
Due to changes coming from the library (nethesis/vue-components#81) several types in the application were not set up correctly. This commit changes the behaviour.
Due to an issue with the `@` import helper the typescript declarations were not honoured correctly. This revamp allows the correct definitions to be consumed on parent projects and enforce typings correctly.
Tbaile
force-pushed
the
type-declaration-fixes
branch
from
82065ed to
172560e
Compare
andre8244
reviewed
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to an issue with the
@import helper the typescript declarations were not honoured correctly. This revamp allows the correct definitions to be consumed on parent projects and enforce typings correctly.