feat: retrieve integration meta data from new endpoint #5647
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request adds or modifies JavaScript ( |
khendrikse
reviewed
May 21, 2024
khendrikse
reviewed
May 21, 2024
lukasholzer
reviewed
May 24, 2024
lukasholzer
reviewed
May 24, 2024
lukasholzer
reviewed
May 24, 2024
lukasholzer
reviewed
May 24, 2024
lukasholzer
reviewed
May 24, 2024
lukasholzer
reviewed
May 24, 2024
packages/config/src/api/site_info.ts
Outdated
Comment on lines
50
to
66
| if (useV2Endpoint) { | ||
| const promises = [ | ||
| getAccounts(api), | ||
| getAddons(api, siteId), | ||
| getIntegrations({ siteId, testOpts, offline, accountId: siteInfo.account_id, featureFlags }), | ||
| ] | ||
|
|
||
| siteInfo.build_settings.env = envelope | ||
| } | ||
| const [accounts, addons, integrations] = await Promise.all(promises) | ||
|
|
||
| if (siteInfo.use_envelope) { | ||
| const envelope = await getEnvelope({ api, accountId: siteInfo.account_slug, siteId, context }) | ||
|
|
||
| siteInfo.build_settings.env = envelope | ||
| } | ||
|
|
||
| return { siteInfo, accounts, addons, integrations } | ||
| } else { |
There was a problem hiding this comment.
what's about mode 'buildbot' shouldn't be this covered in this part as well?
Why is the mode buildbot only covered in the non feature flaged way?
There was a problem hiding this comment.
If I am honest, I don't know why we did this and I opted to keep this as it was previously written so that I could be sure I didn't regress the previous functionality as I am only interested in the adding the v2 behaviour
lemusthelroy
deleted the
lemusthelroy/ct-1160-point-build-system-to-new-endpoint
branch
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Integrations are changing and this also means the endpoint we use to fetch information about integrations installed on a site is also changing. This points to the new endpoint behind a feature flag.
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)