Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1344 enhance prom filters for RTT metrics [1.4 backport] #519

Merged
merged 1 commit into from
Oct 12, 2023

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 11, 2023

Backport of #478
This is necessary for fixing NETOBSERV-1344

no-doc / no-qe on this PR: actual changes are on the operator PR netobserv/network-observability-operator#456

@jotak jotak added no-qe This PR doesn't necessitate QE approval no-doc This PR doesn't require documentation change on the NetObserv operator labels Oct 11, 2023
@nathan-weinberg
Copy link

This is marked no-qe but NETOBSERV-1344 suggests this should be pre-merge tested - please clarify

@jotak
Copy link
Member Author

jotak commented Oct 12, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Oct 12, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot merged commit d6f1e7d into netobserv:release-1.4 Oct 12, 2023
4 checks passed
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 16, 2023
@jotak jotak deleted the prom-encode-enhance branch October 16, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm no-doc This PR doesn't require documentation change on the NetObserv operator no-qe This PR doesn't necessitate QE approval ok-to-test To set manually when a PR is safe to test. Triggers image build on PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants