Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dependencies (kube client, prom model...) (#500) [1.4 backport] #530

Closed
wants to merge 1 commit into from

Conversation

jotak
Copy link
Member

@jotak jotak commented Oct 24, 2023

  • Bump dependencies (kube client, prom model...)

  • Fix service with empty ClusterIP triggering errors

  • Use ClusterIPs list, instead of ClusterIP single field, to check for empty ips
  • Just ignore empty ones rather than throwing an error

Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 (#528)

  • Bump k8s.io/apimachinery from 0.28.2 to 0.28.3

Bumps k8s.io/apimachinery from 0.28.2 to 0.28.3.


updated-dependencies:

  • dependency-name: k8s.io/apimachinery dependency-type: direct:production update-type: version-update:semver-patch ...
  • Add other bumps

* Bump dependencies (kube client, prom model...)

* Fix service with empty ClusterIP triggering errors

- Use ClusterIPs list, instead of ClusterIP single field, to check for
  empty ips
- Just ignore empty ones rather than throwing an error

Bump k8s.io/apimachinery from 0.28.2 to 0.28.3 (netobserv#528)

* Bump k8s.io/apimachinery from 0.28.2 to 0.28.3

Bumps [k8s.io/apimachinery](https://github.com/kubernetes/apimachinery) from 0.28.2 to 0.28.3.
- [Commits](kubernetes/apimachinery@v0.28.2...v0.28.3)

---
updated-dependencies:
- dependency-name: k8s.io/apimachinery
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>

* Add other bumps

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joel Takvorian <[email protected]>
@openshift-ci
Copy link

openshift-ci bot commented Oct 24, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from jotak. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (release-1.4@6027627). Click here to learn what that means.

Additional details and impacted files
@@              Coverage Diff               @@
##             release-1.4     #530   +/-   ##
==============================================
  Coverage               ?   65.99%           
==============================================
  Files                  ?       94           
  Lines                  ?     6935           
  Branches               ?        0           
==============================================
  Hits                   ?     4577           
  Misses                 ?     2099           
  Partials               ?      259           
Flag Coverage Δ
unittests 65.99% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@jpinsonneau jpinsonneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, just ensure flows are not dropped as seen in the metadata PR with similar changes on ClusterIPs checks before merge.

@jotak
Copy link
Member Author

jotak commented Oct 25, 2023

closing per agreement to minimize changes in 1.4.2

@jotak jotak closed this Oct 25, 2023
@jotak jotak deleted the bump-deps-1.4 branch November 1, 2023 08:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants