Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETOBSERV-1466 Update eBPF dependency for FLP #601

Merged
merged 2 commits into from
Mar 12, 2024

Conversation

jpinsonneau
Copy link
Collaborator

@jpinsonneau jpinsonneau commented Feb 20, 2024

Description

See eBPF update netobserv/netobserv-ebpf-agent#275 and followup to remove Duplicate field netobserv/netobserv-ebpf-agent#276

Dependencies

Update go mod once eBPF PR is merged

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

@jpinsonneau jpinsonneau marked this pull request as draft February 20, 2024 09:03
@jpinsonneau jpinsonneau added the breaking-change This pull request has breaking changes. They should be described in PR description. label Feb 21, 2024
@jpinsonneau jpinsonneau changed the title NETOBSERV-1466 append either single or plural fields NETOBSERV-1466 Update eBPF dependency for FLP Feb 21, 2024
@jpinsonneau jpinsonneau marked this pull request as ready for review February 21, 2024 12:19
@jpinsonneau jpinsonneau marked this pull request as draft February 21, 2024 12:43
@jotak jotak added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 1, 2024
@jotak
Copy link
Member

jotak commented Mar 1, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm label Mar 1, 2024
Copy link

github-actions bot commented Mar 1, 2024

New image:
quay.io/netobserv/flowlogs-pipeline:013a597

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=013a597 make set-flp-image

Copy link

openshift-ci bot commented Mar 12, 2024

New changes are detected. LGTM label has been removed.

@github-actions github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Mar 12, 2024
@jpinsonneau jpinsonneau marked this pull request as ready for review March 12, 2024 09:24
Copy link

openshift-ci bot commented Mar 12, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot removed the lgtm label Mar 12, 2024
Copy link

openshift-ci bot commented Mar 12, 2024

New changes are detected. LGTM label has been removed.

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 67.20%. Comparing base (df307e0) to head (8f10ff5).

Files Patch % Lines
pkg/pipeline/write/write_ipfix.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #601   +/-   ##
=======================================
  Coverage   67.19%   67.20%           
=======================================
  Files         104      104           
  Lines        7459     7461    +2     
=======================================
+ Hits         5012     5014    +2     
- Misses       2144     2145    +1     
+ Partials      303      302    -1     
Flag Coverage Δ
unittests 67.20% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-merge-bot openshift-merge-bot bot merged commit 53e97a5 into netobserv:main Mar 12, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved breaking-change This pull request has breaking changes. They should be described in PR description. lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants