WIP NETOBSERV-1471 add tcp write stage #604
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,5 @@ | ||
| package api | ||
|
|
||
| type WriteTCP struct { | ||
| Port string `yaml:"port,omitempty" json:"port,omitempty" doc:"TCP port number"` | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright (C) 2021 IBM, Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| * | ||
| */ | ||
|
|
||
| package write | ||
|
|
||
| import ( | ||
| "encoding/json" | ||
| "fmt" | ||
| "net" | ||
|
|
||
| "github.com/netobserv/flowlogs-pipeline/pkg/config" | ||
| "github.com/sirupsen/logrus" | ||
| ) | ||
|
|
||
| type writeTCP struct { | ||
| address string | ||
| conn net.Conn | ||
| } | ||
|
|
||
| // Write writes a flow to tcp connection | ||
| func (t *writeTCP) Write(v config.GenericMap) { | ||
| logrus.Tracef("entering writeTCP Write") | ||
| b, _ := json.Marshal(v) | ||
| // append new line between each record to split on client side | ||
| b = append(b, []byte("\n")...) | ||
| _, err := t.conn.Write(b) | ||
| if err != nil { | ||
| log.WithError(err).Warn("can't write tcp") | ||
| } | ||
| } | ||
|
|
||
| // NewWriteTCP create a new write | ||
| func NewWriteTCP(params config.StageParam) (Writer, error) { | ||
| logrus.Debugf("entering NewWriteTCP") | ||
| writeTCP := &writeTCP{} | ||
| if params.Write != nil && params.Write.TCP != nil && params.Write.TCP.Port != "" { | ||
| writeTCP.address = ":" + params.Write.TCP.Port | ||
| } else { | ||
| return nil, fmt.Errorf("Write.TCP.Port must be specified") | ||
| } | ||
|
|
||
| logrus.Debugf("NewWriteTCP Listen %s", writeTCP.address) | ||
| l, err := net.Listen("tcp", writeTCP.address) | ||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| defer l.Close() | ||
| clientConn, err := l.Accept() | ||
|
Comment on lines
+57
to
+62
There was a problem hiding this comment. It looks like you are expecting some other entity to initiate a TCP connection to FLP to which FLP will write its flow logs. What is the use case you have in mind? What if I have multiple targets to which I want to send my data via TCP? Can I set up multiple writeTCP stages? How will it work? or do we want to put the listen() operation into a separate thread and accumulate the connections that were attempted and send flow logs to all current connections? There was a problem hiding this comment. This is a temporary PR used in netobserv CLI: netobserv/network-observability-cli#2 (comment) The CLI deploys eBPF agents using If we keep that TCP implementation, we can indeed improve and makes the wait optionnal + allow multiple targets 👍 |
||
| if err != nil { | ||
| return nil, err | ||
| } | ||
| writeTCP.conn = clientConn | ||
|
|
||
| return writeTCP, nil | ||
| } | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix (or remove) Copyright statement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is coming from both eBPF packets exporter and flp stdout write stage 😄
I just copied the code from there but I can remove the copyright if you want.