Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(trivial) Report error when Kafka connection is broken #615

Merged
merged 1 commit into from
Feb 28, 2024

Conversation

jotak
Copy link
Member

@jotak jotak commented Feb 28, 2024

No description provided.

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 66.92%. Comparing base (6e92816) to head (55b61f0).
Report is 1 commits behind head on main.

Files Patch % Lines
pkg/pipeline/ingest/ingest_kafka.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #615      +/-   ##
==========================================
- Coverage   66.95%   66.92%   -0.04%     
==========================================
  Files         104      104              
  Lines        7445     7446       +1     
==========================================
- Hits         4985     4983       -2     
- Misses       2162     2164       +2     
- Partials      298      299       +1     
Flag Coverage Δ
unittests 66.92% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jotak
Copy link
Member Author

jotak commented Feb 28, 2024

thanks!
/approve

Copy link

openshift-ci bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit a140b7f into netobserv:main Feb 28, 2024
9 checks passed
@jotak jotak deleted the report-kafka-err branch March 21, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants