NETOBSERV-1522 & NETOBSERV-1750 FLP otel fixes

[jpinsonneau]

Description

• Fix open telemetry attributes (for arrays)

Attributes:
-> timeflowstart: Int(1720623609511)
-> destination.k8s.name: Str(ip-10-0-1-172.ec2.internal)
-> dns.errno: Int(0)
-> source.mac: Str(02:BF:1A:CD:98:51)
-> host.direction: Int(0)
-> destination.mac: Str(02:60:C1:E6:97:15)
-> destination.k8s.kind: Str(Node)
-> protocol: Int(17)
-> source.k8s.name: Str(ip-10-0-1-125.ec2.internal)
-> source.k8s.kind: Str(Node)
-> destination.address: Str(10.0.1.172)
-> timereceived: Int(1720623613)
-> bytes: Int(124)
-> interface.directions: Slice([0,0])
-> timeflowend: Int(1720623609511)
-> source.k8s.host.name: Str(ip-10-0-1-125.ec2.internal)
-> destination.k8s.owner.kind: Str(Node)
-> destination.k8s.host.name: Str(ip-10-0-1-172.ec2.internal)
-> source.k8s.node.name: Str(ip-10-0-1-125.ec2.internal)
-> source.port: Int(45558)
-> destination.k8s.owner.name: Str(ip-10-0-1-172.ec2.internal)
-> interface.names: Slice(["ens5","br-ex"])
-> source.address: Str(10.0.1.125)
-> destination.port: Int(6081)
-> destination.k8s.host.address: Str(10.0.1.172)
-> packets: Int(1)
-> dscp: Int(0)
-> source.k8s.owner.name: Str(ip-10-0-1-125.ec2.internal)
-> source.k8s.owner.kind: Str(Node)
-> destination.k8s.node.name: Str(ip-10-0-1-172.ec2.internal)
-> source.k8s.host.address: Str(10.0.1.125)
-> k8s.layer: Str(infra)

• Fix FLP crash (see https://issues.redhat.com/browse/NETOBSERV-1750)

Backtrace:

time=2024-07-09T17:41:44Z level=info msg=connecting stages: enrich --> Otel-export-0-metricstime=2024-07-09T17:41:44Z level=info msg=starting PProf HTTP listener port=6060panic: runtime error: invalid memory address or nil pointer dereference[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xbc08a3]
goroutine 151 [running]:github.com/netobserv/flowlogs-pipeline/pkg/pipeline/utils.(*TimedCache).CleanupExpiredEntries(0xc0002f32c0, 0x1bf08eb000, 0x0)	/app/pkg/pipeline/utils/timed_cache.go:144 +0x303github.com/netobserv/flowlogs-pipeline/pkg/pipeline/encode.(*MetricsCommonStruct).cleanupExpiredEntriesLoop(0xc0003245b0, 0x0)	/app/pkg/pipeline/encode/metrics_common.go:261 +0x4ccreated by github.com/netobserv/flowlogs-pipeline/pkg/pipeline/encode.NewMetricsCommonStruct in goroutine 1	/app/pkg/pipeline/encode/metrics_common.go:281 +0x426

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.
• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[codecov]

Codecov Report

Attention: Patch coverage is 24.24242% with 25 lines in your changes missing coverage. Please review.

Project coverage is 64.79%. Comparing base (915552b) to head (d493241).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #684      +/-   ##
==========================================
- Coverage   65.12%   64.79%   -0.33%     
==========================================
  Files         107      107              
  Lines        6844     6869      +25     
==========================================
- Hits         4457     4451       -6     
- Misses       2070     2099      +29     
- Partials      317      319       +2     

Flag	Coverage Δ
unittests	64.79% <24.24%> (-0.33%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/pipeline/utils/timed_cache.go	95.12% <100.00%> (+0.06%)	⬆️
pkg/pipeline/encode/opentelemetry/opentelemetry.go	50.00% <19.35%> (-7.22%)	⬇️

... and 1 file with indirect coverage changes

[github-actions]

New image:
quay.io/netobserv/flowlogs-pipeline:d0af24f

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=d0af24f make set-flp-image

[memodi]

/label qe-approved

[jotak]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment