Skip to content

Commit

Permalink
Remove obsolete comment + update arch chart
Browse files Browse the repository at this point in the history
  • Loading branch information
jotak committed Dec 20, 2024
1 parent 7c34d61 commit 6d2b616
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 14 deletions.
18 changes: 6 additions & 12 deletions docs/architecture.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ The following graph provides a birds' eye view on how the different components a

For more info on each component, please check their corresponding Go docs.

<!-- When editing, you can use an online editor for a live preview, e.g. https://mermaid.live/ -->

### Kernel space

```mermaid
Expand Down Expand Up @@ -33,21 +35,13 @@ flowchart TD
```mermaid
flowchart TD
E(ebpf.FlowFetcher) --> |"pushes via<br/>RingBuffer"| RB(flow.RingBufTracer)
style E fill:#990
style E fill:#4A8
E --> |"polls<br/>HashMap"| M(flow.MapTracer)
RB --> |chan *model.Record| ACC(flow.Accounter)
RB -.-> |flushes| M
ACC --> |"chan []*model.Record"| DD(flow.Deduper)
M --> |"chan []*model.Record"| DD
subgraph Optional
DD
end
DD --> |"chan []*model.Record"| CL(flow.CapacityLimiter)
ACC --> |"chan []*model.Record"| CL(flow.CapacityLimiter)
M --> |"chan []*model.Record"| CL
CL --> |"chan []*model.Record"| DC(flow.Decorator)
DC --> |"chan []*model.Record"| EX("export.GRPCProto<br/>or<br/>export.KafkaProto<br/>or<br/>export.DirectFLP")
CL --> |"chan []*model.Record"| EX("export.GRPCProto<br/>or<br/>export.KafkaProto<br/>or<br/>export.DirectFLP")
```
2 changes: 0 additions & 2 deletions pkg/tracer/tracer_legacy.go
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ func (m *FlowFetcher) legacyLookupAndDeleteMap(met *metrics.Metrics) map[ebpf.Bp
log.WithError(err).WithField("flowId", id).Warnf("couldn't delete flow entry")
met.Errors.WithErrorName("flow-fetcher-legacy", "CannotDeleteFlows").Inc()
}
// We observed that eBFP PerCPU map might insert multiple times the same key in the map
// (probably due to race conditions) so we need to re-join metrics again at userspace
flows[id] = model.NewBpfFlowContent(baseMetrics)
}
met.BufferSizeGauge.WithBufferName("hashmap-legacy-total").Set(float64(count))
Expand Down

0 comments on commit 6d2b616

Please sign in to comment.