NETOBSERV-1379: enhance DNS debugging to dbg DNS over TCP with NA fields #218

msherif1234 · 2023-10-26T15:29:58Z

Description

it was noticed with DNS over TCP that the handshake packets are too small and it doesn't contain any DNS data from UI DNS fields showed as n/a which is true

this PR propagate the DNS lookup return code so we can differentiate between cases like TCP handshake case and real errors enriching with DNS info.

when we get N/A bpf_skb_load_bytes() return an error

working
======
 "dns_record": {
                        "id": 40514,
                        "flags": 34176,
                        "latency": 185794,
                        "errno": 0,
                        "offset": 68,
                        "tcp_len": 34,
                        "skb_len": 291
                    },

none working
==========
 "dns_record": {
                        "id": 0,
                        "flags": 0,
                        "latency": 0,
                        "errno": 7,
                        "offset": 68,
                        "tcp_len": 34,
                        "skb_len": 66
                    },

in the none working case the received packet is very small that is why we can't fetch DNS header info.

Those small packets are TCP handshake and those packets don't have data by definition this clear when u look at the pcap

Dependencies

netobserv/network-observability-console-plugin#425
netobserv/flowlogs-pipeline#533

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

msherif1234 · 2023-10-26T15:30:11Z

/ok-to-test

github-actions · 2023-10-26T15:31:35Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:0fd928e

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=0fd928e make set-agent-image

codecov · 2023-10-26T15:36:24Z

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (0891b34) 31.79% compared to head (d66c036) 31.84%.
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #218      +/-   ##
==========================================
+ Coverage   31.79%   31.84%   +0.05%     
==========================================
  Files          37       37              
  Lines        3362     3369       +7     
==========================================
+ Hits         1069     1073       +4     
- Misses       2230     2232       +2     
- Partials       63       64       +1

Flag	Coverage Δ
unittests	`31.84% <57.14%> (+0.05%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
pkg/decode/decode_protobuf.go	`29.59% <100.00%> (+0.44%)`	⬆️
pkg/exporter/proto.go	`95.27% <100.00%> (+0.07%)`	⬆️
pkg/flow/record.go	`55.22% <0.00%> (-2.59%)`	⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

msherif1234 · 2023-10-26T18:44:51Z

/ok-to-test

github-actions · 2023-10-26T18:46:24Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:a7e6749

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=a7e6749 make set-agent-image

msherif1234 · 2023-10-26T19:32:54Z

/ok-to-test

msherif1234 · 2023-10-26T19:38:18Z

/ok-to-test

github-actions · 2023-10-26T19:39:44Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:ed3a6a6

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=ed3a6a6 make set-agent-image

msherif1234 · 2023-10-27T11:12:50Z

/ok-to-test

github-actions · 2023-10-27T11:14:08Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:35e2cc7

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=35e2cc7 make set-agent-image

msherif1234 · 2023-10-27T12:17:03Z

/ok-to-test

github-actions · 2023-10-27T12:18:28Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:075fb69

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=075fb69 make set-agent-image

openshift-ci-robot · 2023-10-31T11:32:13Z

@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Description

it was noticed with DNS over TCP that the handshake packets are too small and it doesn't contain any DNS data from UI DNS fields showed as n/a which is true

this PR propagate the DNS lookup return code so we can differentiate between cases like TCP handshake case and real errors enriching with DNS info.

when we get N/A bpf_skb_load_bytes() return an error
working
======
"dns_record": {
                       "id": 40514,
                       "flags": 34176,
                       "latency": 185794,
                       "errno": 0,
                       "offset": 68,
                       "tcp_len": 34,
                       "skb_len": 291
                   },

none working
==========
"dns_record": {
                       "id": 0,
                       "flags": 0,
                       "latency": 0,
                       "errno": 7,
                       "offset": 68,
                       "tcp_len": 34,
                       "skb_len": 66
                   },
in the none working case the received packet is very small that is why we can't fetch DNS header info.

Those small packets are TCP handshake and those packets don't have data by definition this clear when u look at the pcap

Dependencies

netobserv/network-observability-console-plugin#425

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msherif1234 · 2023-10-31T13:40:55Z

/ok-to-test

github-actions · 2023-10-31T13:42:34Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:054faa4

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=054faa4 make set-agent-image

msherif1234 · 2023-10-31T15:15:04Z

/ok-to-test

github-actions · 2023-10-31T15:16:45Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:138178c

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=138178c make set-agent-image

Signed-off-by: Mohamed Mahmoud <[email protected]>

msherif1234 · 2023-10-31T15:41:03Z

/ok-to-test

github-actions · 2023-10-31T15:42:41Z

New image:
quay.io/netobserv/netobserv-ebpf-agent:9bed2e9

It will expire after two weeks.

To deploy this build, run from the operator repo, assuming the operator is running:

USER=netobserv VERSION=9bed2e9 make set-agent-image

openshift-ci-robot · 2023-10-31T16:15:13Z

@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Description

it was noticed with DNS over TCP that the handshake packets are too small and it doesn't contain any DNS data from UI DNS fields showed as n/a which is true

this PR propagate the DNS lookup return code so we can differentiate between cases like TCP handshake case and real errors enriching with DNS info.

when we get N/A bpf_skb_load_bytes() return an error
working
======
"dns_record": {
                       "id": 40514,
                       "flags": 34176,
                       "latency": 185794,
                       "errno": 0,
                       "offset": 68,
                       "tcp_len": 34,
                       "skb_len": 291
                   },

none working
==========
"dns_record": {
                       "id": 0,
                       "flags": 0,
                       "latency": 0,
                       "errno": 7,
                       "offset": 68,
                       "tcp_len": 34,
                       "skb_len": 66
                   },
in the none working case the received packet is very small that is why we can't fetch DNS header info.

Those small packets are TCP handshake and those packets don't have data by definition this clear when u look at the pcap

Dependencies

netobserv/network-observability-console-plugin#425
netobserv/flowlogs-pipeline#533

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

jpinsonneau

LGTM, just a note for future improvment.
Thanks @msherif1234 !

jpinsonneau · 2023-11-03T15:13:15Z

pkg/decode/decode_protobuf.go

@@ -90,11 +90,13 @@ func PBFlowToMap(flow *pbflow.Record) config.GenericMap {
 		}
 	}

+	out["DnsErrno"] = flow.GetDnsErrno()


As discussed, my concern here is adding unecessary field on non dns related flows.
We agreed to keep it as is for now.

Amoghrd · 2023-11-06T22:19:10Z

/label qe-approved

openshift-ci-robot · 2023-11-06T22:19:15Z

@msherif1234: This pull request references NETOBSERV-1379 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.15.0" version, but no target version was set.

In response to this:

Description

it was noticed with DNS over TCP that the handshake packets are too small and it doesn't contain any DNS data from UI DNS fields showed as n/a which is true

this PR propagate the DNS lookup return code so we can differentiate between cases like TCP handshake case and real errors enriching with DNS info.

when we get N/A bpf_skb_load_bytes() return an error
working
======
"dns_record": {
                       "id": 40514,
                       "flags": 34176,
                       "latency": 185794,
                       "errno": 0,
                       "offset": 68,
                       "tcp_len": 34,
                       "skb_len": 291
                   },

none working
==========
"dns_record": {
                       "id": 0,
                       "flags": 0,
                       "latency": 0,
                       "errno": 7,
                       "offset": 68,
                       "tcp_len": 34,
                       "skb_len": 66
                   },
in the none working case the received packet is very small that is why we can't fetch DNS header info.

Those small packets are TCP handshake and those packets don't have data by definition this clear when u look at the pcap

Dependencies

netobserv/network-observability-console-plugin#425
netobserv/flowlogs-pipeline#533

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

Will this change affect NetObserv / Network Observability operator? If not, you can ignore the rest of this checklist.

Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).

Does this PR require product documentation?

If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.

Does this PR require a product release notes entry?

If so, fill in "Release Note Text" in the JIRA.

Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.

If so, make sure it is described in the JIRA ticket.

QE requirements (check 1 from the list):

Standard QE validation, with pre-merge tests unless stated otherwise.

Regression tests only (e.g. refactoring with no user-facing change).

No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

msherif1234 · 2023-11-06T22:51:44Z

/approve

openshift-ci · 2023-11-06T22:51:50Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: msherif1234

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [msherif1234]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci bot added the do-not-merge/work-in-progress label Oct 26, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 26, 2023

msherif1234 force-pushed the dns_na_issue branch from 87333bf to 808d225 Compare October 26, 2023 18:44

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 26, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 26, 2023

msherif1234 force-pushed the dns_na_issue branch from 808d225 to 3d702de Compare October 26, 2023 19:32

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 26, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 26, 2023

msherif1234 force-pushed the dns_na_issue branch from 3d702de to 3ec35b6 Compare October 27, 2023 11:12

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 27, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 27, 2023

msherif1234 force-pushed the dns_na_issue branch from 3ec35b6 to 6dcac32 Compare October 27, 2023 12:16

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 27, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 27, 2023

msherif1234 force-pushed the dns_na_issue branch from 6dcac32 to e986454 Compare October 27, 2023 15:52

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 27, 2023

msherif1234 force-pushed the dns_na_issue branch 2 times, most recently from 9abb630 to 688063a Compare October 29, 2023 10:35

jpinsonneau mentioned this pull request Oct 31, 2023

NETOBSERV-1379: show DNS error number netobserv/network-observability-console-plugin#425

Merged

10 tasks

msherif1234 mentioned this pull request Oct 31, 2023

NETOBSERV-1379: enhance DNS debugging to dbg DNS over TCP netobserv/flowlogs-pipeline#533

Merged

11 tasks

msherif1234 force-pushed the dns_na_issue branch from 688063a to 7677052 Compare October 31, 2023 13:40

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023

msherif1234 force-pushed the dns_na_issue branch from 7677052 to 3b31afe Compare October 31, 2023 15:14

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023

dbg DNS over TCP NA fields

d66c036

Signed-off-by: Mohamed Mahmoud <[email protected]>

msherif1234 force-pushed the dns_na_issue branch from 3b31afe to d66c036 Compare October 31, 2023 15:39

github-actions bot removed the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023

openshift-ci bot added the ok-to-test To set manually when a PR is safe to test. Triggers image build on PR. label Oct 31, 2023

jpinsonneau approved these changes Nov 3, 2023

View reviewed changes

openshift-ci bot assigned jpinsonneau Nov 3, 2023

openshift-ci bot added the lgtm label Nov 3, 2023

openshift-ci bot added the qe-approved QE has approved this pull request label Nov 6, 2023

openshift-ci bot added the approved label Nov 6, 2023

openshift-merge-bot bot merged commit d69703f into netobserv:main Nov 6, 2023
10 checks passed

NETOBSERV-1379: enhance DNS debugging to dbg DNS over TCP with NA fields #218

NETOBSERV-1379: enhance DNS debugging to dbg DNS over TCP with NA fields #218

Conversation

msherif1234 commented Oct 26, 2023 • edited Loading

Description

Dependencies

Checklist

msherif1234 commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

codecov bot commented Oct 26, 2023 • edited Loading

Codecov Report

msherif1234 commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

msherif1234 commented Oct 26, 2023

msherif1234 commented Oct 26, 2023

github-actions bot commented Oct 26, 2023

msherif1234 commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

msherif1234 commented Oct 27, 2023

github-actions bot commented Oct 27, 2023

openshift-ci-robot commented Oct 31, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

msherif1234 commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

msherif1234 commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

msherif1234 commented Oct 31, 2023

github-actions bot commented Oct 31, 2023

openshift-ci-robot commented Oct 31, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

jpinsonneau left a comment

Choose a reason for hiding this comment

jpinsonneau Nov 3, 2023

Choose a reason for hiding this comment

Amoghrd commented Nov 6, 2023

openshift-ci-robot commented Nov 6, 2023 • edited by openshift-ci bot Loading

Description

Dependencies

Checklist

msherif1234 commented Nov 6, 2023

openshift-ci bot commented Nov 6, 2023

msherif1234 commented Oct 26, 2023 •

edited

Loading

codecov bot commented Oct 26, 2023 •

edited

Loading

openshift-ci-robot commented Oct 31, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Oct 31, 2023 •

edited by openshift-ci bot

Loading

openshift-ci-robot commented Nov 6, 2023 •

edited by openshift-ci bot

Loading